Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffergeometryutils deprecations #396

Merged

Conversation

Mik-pe
Copy link
Contributor

@Mik-pe Mik-pe commented Apr 4, 2023

Why

r151 of ThreeJS renamed some functions in BufferGeometryUtils

What

The two functions has been comment-tagged as deprecated and the renamed functions are added.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Mik-pe Mik-pe force-pushed the add-buffergeometryutils-deprecations branch from 3a0d1f7 to a92eb60 Compare April 4, 2023 12:01
@Mik-pe Mik-pe changed the base branch from dev to master April 4, 2023 12:04
@Methuselah96 Methuselah96 mentioned this pull request Apr 25, 2023
37 tasks
@Methuselah96 Methuselah96 changed the base branch from master to dev April 25, 2023 12:45
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Methuselah96 Methuselah96 merged commit bc5c673 into three-types:dev Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants