Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bitbucket retriever #2611

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

CollinsC1O
Copy link
Contributor

@CollinsC1O CollinsC1O commented Nov 3, 2024

Resolve #2561

Copy link

netlify bot commented Nov 3, 2024

Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit da4437c
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/672e3aac62ccfe0008a8a3ea
😎 Deploy Preview https://deploy-preview-2611--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CollinsC1O thanks a lot for this pull request.
We are going to the right direction, I have made a few suggestion and pin point some issue.

I let you review them, and let me know if you need any help.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
cmd/relayproxy/config/retriever.go Outdated Show resolved Hide resolved
cmd/relayproxy/service/gofeatureflag.go Outdated Show resolved Hide resolved
retriever/bitbucketretriever/retriever.go Outdated Show resolved Hide resolved
retriever/bitbucketretriever/retriever.go Outdated Show resolved Hide resolved
retriever/bitbucketretriever/retriever.go Outdated Show resolved Hide resolved
retriever/bitbucketretriever/retriever.go Show resolved Hide resolved
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 86.30137% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (3525e70) to head (da4437c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
retriever/bitbucketretriever/retriever.go 84.12% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2611      +/-   ##
==========================================
+ Coverage   85.00%   85.02%   +0.01%     
==========================================
  Files         103      104       +1     
  Lines        4763     4834      +71     
==========================================
+ Hits         4049     4110      +61     
- Misses        566      573       +7     
- Partials      148      151       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinsC1O
Copy link
Contributor Author

Hello @thomaspoignant so I just made some changes.

Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CollinsC1O thanks for your update but it seems that your commit 92818f3 has removed all recent new features that we have introduce recently.

Can you try to check what happened?
My guess is that the resynchronisation of your repo did not work properly.

I also so that you did not addressed the comments about the README.md file #2611 (comment) and about the change in the relay proxy configuration #2611 (comment) and #2611 (comment).

cmd/relayproxy/service/gofeatureflag.go Show resolved Hide resolved
@CollinsC1O CollinsC1O closed this Nov 6, 2024
@CollinsC1O CollinsC1O force-pushed the bit_bucket_retriever branch from 14be276 to cba1570 Compare November 6, 2024 18:03
@CollinsC1O CollinsC1O reopened this Nov 6, 2024
Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some issues, you have removed some existing feature in this PR.

cmd/relayproxy/service/gofeatureflag.go Outdated Show resolved Hide resolved
cmd/relayproxy/service/gofeatureflag.go Outdated Show resolved Hide resolved
@CollinsC1O
Copy link
Contributor Author

Hello @thomaspoignant. Corrections have been implemented, waiting for your review

Copy link

sonarqubecloud bot commented Nov 8, 2024

Repository owner deleted a comment from kodiakhq bot Nov 8, 2024
@kodiakhq kodiakhq bot merged commit 012ea4c into thomaspoignant:main Nov 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(feature) Bitbucket retriever
2 participants