-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Bitbucket retriever #2611
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CollinsC1O thanks a lot for this pull request.
We are going to the right direction, I have made a few suggestion and pin point some issue.
I let you review them, and let me know if you need any help.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
+ Coverage 85.00% 85.02% +0.01%
==========================================
Files 103 104 +1
Lines 4763 4834 +71
==========================================
+ Hits 4049 4110 +61
- Misses 566 573 +7
- Partials 148 151 +3 ☔ View full report in Codecov by Sentry. |
Hello @thomaspoignant so I just made some changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CollinsC1O thanks for your update but it seems that your commit 92818f3 has removed all recent new features that we have introduce recently.
Can you try to check what happened?
My guess is that the resynchronisation of your repo did not work properly.
I also so that you did not addressed the comments about the README.md
file #2611 (comment) and about the change in the relay proxy configuration #2611 (comment) and #2611 (comment).
14be276
to
cba1570
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some issues, you have removed some existing feature in this PR.
Hello @thomaspoignant. Corrections have been implemented, waiting for your review |
349e88c
to
8e32ce6
Compare
Quality Gate passedIssues Measures |
Resolve #2561