add test for default branch

thomaspoignant · Nov 8, 2024 · da4437c · da4437c
1 parent 11315b8
commit da4437c
Showing 1 changed file with 22 additions and 2 deletions.
diff --git a/cmd/relayproxy/service/gofeatureflag_test.go b/cmd/relayproxy/service/gofeatureflag_test.go
@@ -185,12 +185,11 @@ func Test_initRetriever(t *testing.T) {
 			},
 		},
 		{
-			name:    "Convert Bitbucket Retriever",
+			name:    "Convert Bitbucket Retriever default branch",
 			wantErr: assert.NoError,
 			conf: &config.RetrieverConf{
 				Kind:           "bitbucket",
 				RepositorySlug: "gofeatureflag/config-repo",
-				Branch:         "main",
 				Path:           "flags/config.goff.yaml",
 				AuthToken:      "XXX_BITBUCKET_TOKEN",
 				BaseURL:        "https://api.bitbucket.goff.org",
@@ -205,6 +204,27 @@ func Test_initRetriever(t *testing.T) {
 			},
 			wantType: &bitbucketretriever.Retriever{},
 		},
+		{
+			name:    "Convert Bitbucket Retriever branch specified",
+			wantErr: assert.NoError,
+			conf: &config.RetrieverConf{
+				Kind:           "bitbucket",
+				Branch:         "develop",
+				RepositorySlug: "gofeatureflag/config-repo",
+				Path:           "flags/config.goff.yaml",
+				AuthToken:      "XXX_BITBUCKET_TOKEN",
+				BaseURL:        "https://api.bitbucket.goff.org",
+			},
+			want: &bitbucketretriever.Retriever{
+				RepositorySlug: "gofeatureflag/config-repo",
+				Branch:         "develop",
+				FilePath:       "flags/config.goff.yaml",
+				BitBucketToken: "XXX_BITBUCKET_TOKEN",
+				BaseURL:        "https://api.bitbucket.goff.org",
+				Timeout:        10000000000,
+			},
+			wantType: &bitbucketretriever.Retriever{},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {