fix(localMeta): Ignore deleted delegated targets #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaptisteFoy
force-pushed
the
fix/ignore-deleted-delegated-targets-in-localmeta
branch
2 times, most recently
from
766e2ed
to
474e696
Compare
mellon85
approved these changes
Jul 21, 2023
trishankatdatadog
force-pushed
the
fix/ignore-deleted-delegated-targets-in-localmeta
branch
from
caed9d3
to
82e43d3
Compare
trishankatdatadog
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Sorry for the delay, @BaptisteFoy!
LGTM, although I have to say I'm not happy with the rather convoluted delegations code overall in go-tuf (although hopefully go-tuf-metadata will replace it soon).
@rdimitrov WDYT?
rdimitrov
approved these changes
Oct 12, 2023
Signed-off-by: Baptiste Foy <baptiste.foy@datadoghq.com>
rdimitrov
force-pushed
the
fix/ignore-deleted-delegated-targets-in-localmeta
branch
from
82e43d3
to
6e1d194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#384 didn't fix the whole issue it intended to fix, this PR intends to complete it.
Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
The way #384 works is that, to add delegated targets to the
localMetawhile verifying them (as requested per #384 (comment)), it will fetch target files and verify the whole delegation chain to add delegated targets to thelocalMeta(as loadLocalMetaFromSnapshot leverages thelocalMeta). To do so, as thelocalMetais empty and can't be leveraged, we pull delegated targets and target files from the remote store.The problem is that such files can be deleted in the remote store in the mean time, leading to two errors:
ErrMissingRemoteMetadatais the delegated targets file was deleted and removed from the snapshotErrUnknownTargetis a target file was deletedThis PR ignores these errors as they are part of the normal behaviour of the
localMetaload algorithm. Note that it doesn't fix #444.Please verify and check that the pull request fulfills the following requirements: