Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product targets not in a target file delegation paths are not added to the localMeta #444

Closed
BaptisteFoy opened this issue Jan 6, 2023 · 0 comments · Fixed by #522
Closed

Comments

@BaptisteFoy
Copy link
Contributor

Delegated targets were not added to the localMeta structure (which is an in-memory cache of the local storage) until #384. While the PR adds any delegated target that is part of a path from the top targets to a target file, it doesn't match all delegated targets.

For instance, if we have the following structure of delegation:

targets
 └── a.json
   └── b.json
      └── c.json
      └── d.json
        └── target_file.txt

Then only a.json, b.json, and d.json will be added to the localMeta, but not c.json. As c.json isn't in any target file path, it shouldn't need to be in the localMeta, as they shouldn't even be required or downloaded.

It's not a big deal, but opening an issue lets us track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant