Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host: trace: revert host traces to fprintf #548

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

bkokoszx
Copy link
Collaborator

@bkokoszx bkokoszx commented Nov 7, 2018

Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com

@bkokoszx bkokoszx force-pushed the revert-host-traces branch 3 times, most recently from bea10b4 to 4196244 Compare November 7, 2018 16:44
@sofci
Copy link
Collaborator

sofci commented Nov 8, 2018

Can one of the admins verify this patch?

@xiulipan
Copy link
Contributor

xiulipan commented Nov 8, 2018

SOFCI TEST

@lgirdwood
Copy link
Member

@bkokoszx can you check the travis CI, lost of build errors for host. Btw, did you run the host build all script ?

@bkokoszx
Copy link
Collaborator Author

bkokoszx commented Nov 8, 2018

@lgirdwood
I'm aware of CI failure. I'm working on that now.

Copy link
Contributor

@mwierzbix mwierzbix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution but please do fix whitespace changes.

src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Outdated Show resolved Hide resolved
src/include/sof/trace.h Show resolved Hide resolved
src/host/trace.c Show resolved Hide resolved
@bkokoszx bkokoszx force-pushed the revert-host-traces branch 3 times, most recently from bfdd7a3 to 838184e Compare November 8, 2018 12:50
src/host/trace.c Outdated Show resolved Hide resolved
@bkokoszx bkokoszx force-pushed the revert-host-traces branch 2 times, most recently from 6f0d1a4 to a9c9dda Compare November 8, 2018 14:11
Host doesn't use trace mechanism - I've reverted
all host traces to simple fprintf.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
@bkokoszx
Copy link
Collaborator Author

bkokoszx commented Nov 8, 2018

@lgirdwood
It looks like travis is ok now. Internal Ci fails, because of #553

@lgirdwood lgirdwood merged commit 9b376d7 into thesofproject:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants