Regression: sof-logger doesn't work with -t parameter

[keqiaozhang]

This is a firmware regression and it's caused by commit: 9af90ce
PR #530

error message:

chronos@localhost /root $ sudo ./sof-logger -l sof-apl.ldc -t
Password:
 CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME        CONTENT
Error: Invalid filename length.

[akloniex]

@lgirdwood @bkokoszx @keqiaozhang
Issue is caused by misalignment between FW and sof-logger.
Expected to be solved as soon as thesofproject/soft#118 is merged and sof-logger rebuilt.

[mengdonglin]

@akloniex @lrgirdwo May we request any PR/commit with ABI change add keyword "ABI" in the subject to highlight the risk? And this PR should mention the soft PR in the body. Ideally, the SOFT update should be backward compatible and be merged at first before the SOF PR.

[ZhendanYang]

sof-logger doesn't work even without -t on CNL:

test@test-CannonLake:~$ sudo ./sof-logger -l sof-cnl.ldc-11.9
 CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME	CONTENT
Error: Invalid filename length. 
test@test-CannonLake:~$ sudo ./sof-logger -l sof-cnl.ldc-11.9 -t
 CORE  LEVEL  COMP_ID        TIMESTAMP            DELTA                FILE_NAME	CONTENT
Error: Invalid filename length. 

[mengdonglin]

@bkokoszx Are all the PR low necessary to fix this issue? Anything missing?

SOFT: thesofproject/soft#118
FW part: #530
Linux part: thesofproject/linux#222

[bkokoszx]

@mengdonglin
Also FW PR I've made yesterday: #548

[bkokoszx]

@keqiaozhang
Could you verify if issue still reproduces?

[keqiaozhang]

@bkokoszx
Confirmed that this issue is fixed on UP^2.
For Yorp, there's one blocker issue with top sof-master :thesofproject/linux#277
so there's no trace log available, but the "Error: Invalid filename length." is gone.
@markyang
please help to confirm this issue on other platform. Thanks~

[markyang]

@bkokoszx @keqiaozhang
This issue has been fixed on BYT, APL and CNL.

[markyang]

There's no trace log available on BYT because of a blocker issue thesofproject/linux#233

[keqiaozhang]

Thanks @markyang for your confirmation, this issue can be closed now.