Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC timed out after boot on Yorp #277

Closed
keqiaozhang opened this issue Nov 13, 2018 · 4 comments
Closed

IPC timed out after boot on Yorp #277

keqiaozhang opened this issue Nov 13, 2018 · 4 comments
Assignees
@ranj063
Labels
bug Something isn't working GLK Applies to Gemini Lake P1 Blocker bugs or important features

Comments

@keqiaozhang
Copy link
Collaborator

This regression is caused by the ABI change, since the ABI is changed in firmware side, but the according kernel PR /pull/260 is missing in cros-sof-v4.14-rebase branch.

dmesg log:

[    5.049045] sof-audio sof-audio: firmware boot complete
[    5.049057] sof-audio sof-audio: Debug PCIR: 00000000 at  00000048
[    5.049059] sof-audio sof-audio: Debug PCIW: 00000002 at  00000048
[    5.049064] sof-audio sof-audio: Debug PCIR: 00000000 at  00000044
[    5.049066] sof-audio sof-audio: Debug PCIW: 00000000 at  00000044
[    5.049120] sof-audio sof-audio: generating page table for ffffa74902fe2000 size 0x10000 pages 16
[    5.049122] sof-audio sof-audio: dma_trace_pages: 16
[    5.049159] sof-audio sof-audio: period_bytes:0x0
[    5.049160] sof-audio sof-audio: periods:1
[    5.049166] sof-audio sof-audio: stream_tag: 1
[    5.049181] sof-audio sof-audio: ipc tx: 0x90010000
[    5.352024] sof-audio sof-audio: error: ipc timed out for 0x90010000 size 0x1c
[    5.352037] sof-audio sof-audio: unknown ROM status value ffffffff
[    5.352183] sof-audio sof-audio: error: unexpected fault 0xffffffff trace 0xffffffff
[    5.352196] sof-audio sof-audio: error: can't set params for DMA for trace -110
[    5.352210] sof-audio sof-audio: warning: failed to initialize trace -110
[    5.352339] sof-audio sof-audio: created machine glk_da7219_max98357a

kernel driver- ranja063-cros-sof-v4.14-rebase:a38231
sof-master:73475e
soft-master:2cd668c
@keqiaozhang keqiaozhang added bug Something isn't working P1 Blocker bugs or important features br-cros GLK Applies to Gemini Lake labels Nov 13, 2018
@ranj063
Copy link
Collaborator

ranj063 commented Nov 13, 2018

@keqiaozhang thanks. I will update the cros branch after the ABI changes have been validated

@keqiaozhang keqiaozhang mentioned this issue Nov 13, 2018
Closed
@mengdonglin
Copy link
Collaborator

mengdonglin commented Nov 13, 2018 •
edited
Loading

@ranj063 Please hold on backporting PR /pull/260 to the topic/cros-4.14-rebase branch. Please backport after release for this week is done.

Firmware glk-004-drop-stable branch plan to introduce ABI update for IPC refinement AFTER the release this week. Only SOF master branch has the ABI update atm.

@plbossart
Copy link
Member

@mengdonglin there is no plan to provide a different driver so firmware HAS to update. The ABI change was reviewed and no one from the firmware team chimed in, so silence means consent...

@mengdonglin
Copy link
Collaborator

Closing this issue because now kernel branch topic/cros-sof-v4.14-rebase is aligned with FW branch glk-004-drop-stable. And FW branch glk-004-drop-stable will not include any ABI change if not necessary for a hot fix.

So ABI update like thesofproject/sof@9af90ce will not be included in glk-004-drop-stable. Thus no need to backport PR /pull/260 to the topic/cros-4.14-rebase branch.

aiChaoSONG pushed a commit to aiChaoSONG/linux that referenced this issue May 24, 2021
@alex
Merge pull request thesofproject#277 from obviyus/rust
3729708 
CI: add ccache
bardliao pushed a commit to bardliao/linux that referenced this issue Nov 22, 2023
@ummakynes
netfilter: nf_tables: Unbreak audit log reset
9b5ba5c 
Deliver audit log from __nf_tables_dump_rules(), table dereference at
the end of the table list loop might point to the list head, leading to
this crash.

[ 4137.407349] BUG: unable to handle page fault for address: 00000000001f3c50
[ 4137.407357] #PF: supervisor read access in kernel mode
[ 4137.407359] #PF: error_code(0x0000) - not-present page
[ 4137.407360] PGD 0 P4D 0
[ 4137.407363] Oops: 0000 [#1] PREEMPT SMP PTI
[ 4137.407365] CPU: 4 PID: 500177 Comm: nft Not tainted 6.5.0+ thesofproject#277
[ 4137.407369] RIP: 0010:string+0x49/0xd0
[ 4137.407374] Code: ff 77 36 45 89 d1 31 f6 49 01 f9 66 45 85 d2 75 19 eb 1e 49 39 f8 76 02 88 07 48 83 c7 01 83 c6 01 48 83 c2 01 4c 39 cf 74 07 <0f> b6 02 84 c0 75 e2 4c 89 c2 e9 58 e5 ff ff 48 c7 c0 0e b2 ff 81
[ 4137.407377] RSP: 0018:ffff8881179737f0 EFLAGS: 00010286
[ 4137.407379] RAX: 00000000001f2c50 RBX: ffff888117973848 RCX: ffff0a00ffffff04
[ 4137.407380] RDX: 00000000001f3c50 RSI: 0000000000000000 RDI: 0000000000000000
[ 4137.407381] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000ffffffff
[ 4137.407383] R10: ffffffffffffffff R11: ffff88813584d200 R12: 0000000000000000
[ 4137.407384] R13: ffffffffa15cf709 R14: 0000000000000000 R15: ffffffffa15cf709
[ 4137.407385] FS:  00007fcfc18bb580(0000) GS:ffff88840e700000(0000) knlGS:0000000000000000
[ 4137.407387] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 4137.407388] CR2: 00000000001f3c50 CR3: 00000001055b2001 CR4: 00000000001706e0
[ 4137.407390] Call Trace:
[ 4137.407392]  <TASK>
[ 4137.407393]  ? __die+0x1b/0x60
[ 4137.407397]  ? page_fault_oops+0x6b/0xa0
[ 4137.407399]  ? exc_page_fault+0x60/0x120
[ 4137.407403]  ? asm_exc_page_fault+0x22/0x30
[ 4137.407408]  ? string+0x49/0xd0
[ 4137.407410]  vsnprintf+0x257/0x4f0
[ 4137.407414]  kvasprintf+0x3e/0xb0
[ 4137.407417]  kasprintf+0x3e/0x50
[ 4137.407419]  nf_tables_dump_rules+0x1c0/0x360 [nf_tables]
[ 4137.407439]  ? __alloc_skb+0xc3/0x170
[ 4137.407442]  netlink_dump+0x170/0x330
[ 4137.407447]  __netlink_dump_start+0x227/0x300
[ 4137.407449]  nf_tables_getrule+0x205/0x390 [nf_tables]

Deliver audit log only once at the end of the rule dump+reset for
consistency with the set dump+reset.

Ensure audit reset access to table under rcu read side lock. The table
list iteration holds rcu read lock side, but recent audit code
dereferences table object out of the rcu read lock side.

Fixes: ea078ae ("netfilter: nf_tables: Audit log rule reset")
Fixes: 7e9be11 ("netfilter: nf_tables: Audit log setelem reset")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Acked-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranj063 ranj063

Labels
bug Something isn't working GLK Applies to Gemini Lake P1 Blocker bugs or important features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@plbossart @ranj063 @mengdonglin @keqiaozhang