Add Intuitive Permission Toggle to Welcome Page #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
added
kind/enhancement
|
#127 is scoped to Firefox but this introduces a UI change for all browsers. Is there a benefit of having this for Chrome too, or should the new UI component be modified to only show on Firefox? BTW, it should be possible to do the eslint checking locally so you don't run into it on CI. |
djahandarie
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #127 by adding a toggle on the welcome page, which enables the <all_urls> origin permission, and links to the permission page.
(ESLint seems to be complaining about this, I can't for the life of me figure out why. It passes fine locally).