Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Firefox) Intuitive UI to grant permissions for websites #127

Closed
Aquafina-water-bottle opened this issue Apr 8, 2023 · 2 comments
Closed
Labels
browser/firefox The issue is Firefox-only kind/enhancement The issue or PR is a new feature or request priority/high High priority issue/PR triage/accepted The issue or PR is ready to be actively worked on

Comments

@Aquafina-water-bottle
Copy link

For Firefox, the extension does not work unless the user explicitly allows Yomitan to work on each individual site, or unless the user stumbles their way into the extension settings -> permissions tab -> set Access your data for all websites to true. This is expected behavior, as shown below:

In MV2, host permissions are granted by the user at the time of install and there’s no elegant way for the user to change this setting (short of uninstalling/reinstalling and choosing different permissions). But with the new extensions button in MV3 in Firefox, users will have easy access and persistent control over which extensions can access any web page, at any time. Users are free to grant ongoing access to a website, or make a choice per visit. To enable this, MV3 treats host permissions (listed in the extension manifest) as opt-in. 1

We can likely use permissions.request() to ask the user to grant the permission automatically on welcome page startup, and include a button somewhere in the welcome page and settings if they still haven't set the permission.

Additional reading:

Footnotes

  1. https://blog.mozilla.org/addons/2022/11/17/unified-extensions-button-and-how-to-handle-permissions-in-manifest-v3/

@Aquafina-water-bottle Aquafina-water-bottle added kind/enhancement The issue or PR is a new feature or request browser/firefox The issue is Firefox-only labels Apr 8, 2023
@djahandarie djahandarie added priority/high High priority issue/PR triage/accepted The issue or PR is ready to be actively worked on labels Apr 9, 2023
@EwanFox
Copy link

EwanFox commented Jun 15, 2023

Firefox(and probably all other browsers) only allows requesting permissions in a user input handler, meaning that requesting on welcome page startup isn't possible. The permissions page already has a button to request the required permissions, but it's hard to find for users, so the answer is probably to integrate this into the setting/welcome pages.

@djahandarie
Copy link
Collaborator

Resolved by #214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser/firefox The issue is Firefox-only kind/enhancement The issue or PR is a new feature or request priority/high High priority issue/PR triage/accepted The issue or PR is ready to be actively worked on
Projects
None yet
Development

No branches or pull requests

3 participants