-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add responsive button view ( mobile, tablet, desktop ) in code example block #1053
Conversation
Run & review this pull request in StackBlitz Codeflow. |
cc: @jjagielka Flowbite site uses iFrame and Flowbite-Svelte doesn't. This means some of components are not suitable for this. Using this PR, some of examples will have a problem:
We need to add the |
I actually didn't think that media queries wouldn't work; |
I meant we need to use this example by example since some of them break the style. |
@shinokada |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your PR. |
I think the current code doesn't give any benefits of having responsive buttons since the styles don't change. |
The only solution would be to implement an iframe similar to what's used on the flowbite.com website. While Tailwind CSS also offers container-based breakpoints, this approach presents issues when working with the components directly. I conducted some experiments to generate iframes using the current codebase and successfully replicated the components within the iframe. However, the JavaScript logic (such as clicks, etc.) is missing. Do you believe it would be possible to reach out to the creators of the |
I believe I've come up with a creative solution! 😱 |
Yes, please create a PR. |
@gi4no Can you have a look at this issue, please? |
Closes #
📑 Description
adding three view toggle buttons: Mobile, Tablet, and Desktop; same as https://flowbite.com/ code preview.
adding also the meta
hideResponsiveButton
for hide buttons when don't need itStatus
✅ Checks
ℹ Additional Information