Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed mb5 class from AvatarGroup component #470

Closed
wants to merge 1 commit into from

Conversation

AZensky
Copy link

@AZensky AZensky commented Dec 4, 2022

Description

  • Removed mb-5 class from AvatarGroup component (flowbite-react/src/lib/theme/default.ts, line 116)

Fixes #467

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Checked to see if mb-5 class was removed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@@ -52,6 +52,7 @@
"@floating-ui/react-dom-interactions": "^0.9.1",
"classnames": "^2.3.2",
"commitizen": "^4.2.5",
"flowbite-react": "^0.3.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to include the flowbite-react here. So, there is no need to also update the package-lock.json and yarn.lock files. Could you please revert these changes?

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 97.34% // Head: 97.34% // No change to project coverage 👍

Coverage data is based on head (3bb2a45) compared to base (cd26e24).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         127      127           
  Lines        5348     5348           
  Branches      436      436           
=======================================
  Hits         5206     5206           
  Misses        142      142           
Impacted Files Coverage Δ
src/lib/theme/default.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders
Copy link
Collaborator

rluders commented Dec 22, 2022

@AZensky do you have plans to continue this PR?

@rluders rluders closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AvatarGroup has unecessary margin
2 participants