Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AvatarGroup has unecessary margin #467

Closed
rluders opened this issue Dec 4, 2022 · 1 comment
Closed

AvatarGroup has unecessary margin #467

rluders opened this issue Dec 4, 2022 · 1 comment
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers

Comments

@rluders
Copy link
Collaborator

rluders commented Dec 4, 2022

Describe the bug

This is a change to the flowbite-react default theme. The AvatarGroup component has an unnecessary mb-5 that needs to be removed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to storybook
  2. Click on Avatar > Grouped
  3. Inspect the AvagarGroup base HTML tag
  4. See unnecessary mb-5 there

Expected behavior

It should NOT have the mb-5.

Screenshots

N/A

System information:

N/A

Project information:

  • Tailwind: 3.0.0
  • Flowbite: 1.4.7
  • Flowbite React: 0.3.5
  • Type: CRA

Additional context

The fix is very easy, just remove it from here:

flowbite-react/src/lib/theme/default.ts

Line 116 in cd26e24

base: 'flex mb-5 -space-x-4',

@rluders rluders added 🐛 bug Something isn't working good first issue Good for newcomers confirmed This bug was confirmed labels Dec 4, 2022
@MaverickDe
Copy link

Can I get assigned this

@rluders rluders mentioned this issue Dec 5, 2022
Closed
10 tasks
rluders pushed a commit to rluders/flowbite-react that referenced this issue Dec 23, 2022
fix(avatargroup): remove mb-5 closes themesberg#467
458c991
rluders pushed a commit to rluders/flowbite-react that referenced this issue Jan 11, 2023
fix(avatargroup): remove mb-5 closes themesberg#467
07c18bf
rluders pushed a commit to rluders/flowbite-react that referenced this issue Jan 11, 2023
fix(avatargroup): remove mb-5 closes themesberg#467
89cc4b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working confirmed This bug was confirmed good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed mb5 class from AvatarGroup component AZensky/flowbite-react
2 participants
@rluders @MaverickDe