Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): display text only on Sidebar.Item tooltip #315

Merged
merged 2 commits into from
Jul 31, 2022
Merged

fix(component): display text only on Sidebar.Item tooltip #315

merged 2 commits into from
Jul 31, 2022

Commits on Jul 31, 2022

  1. fix(component): display text only on Sidebar.Item tooltip 

    When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a
`Tooltip` with its text content. That isn't how it worked up until now.

resolve themesberg#258
    @tulup-conner
    tulup-conner committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    39c8357 View commit details
    Browse the repository at this point in the history

  2. test(component): drop false-positive Sidebar tests 

    I don't think we can rely on a fake DOM environment to test hover states correctly. We should write
integration tests for `<Sidebar collapsed/>` behavior in `cypress`.
    @tulup-conner
    tulup-conner committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    e665b42 View commit details
    Browse the repository at this point in the history