Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misbehavior for sidebar when collapsed #258

Closed
rluders opened this issue Jul 4, 2022 · 1 comment
Closed

Misbehavior for sidebar when collapsed #258

rluders opened this issue Jul 4, 2022 · 1 comment
Assignees
@tulup-conner
Labels
🐛 bug Something isn't working confirmed This bug was confirmed

Comments

@rluders
Copy link
Collaborator

rluders commented Jul 4, 2022

Describe the bug

The sidebar, when collapsed is acting weird:

  • It shows the badge
  • It makes the whole children as its tooltip (even the icon)

To Reproduce
Steps to reproduce the behavior:

  1. Create a CRA project with flowbite-react
  2. Create the sidebar menu as described in the documentation (with icons and labels)
  3. Change its attribute to be collapsed <Sidebar collapsed={true} ...>...</Sidebar>
  4. Hover the mouse hover to see the issue

Expected behavior

  • When collapse it should NOT display the Badge, ONLY the icon
  • The content of Tooptip must be or the original children or/and also allow it to be overwrite by Sidebar.Item property

Screenshots

localhost_3000_

Additional context
n/a
@rluders rluders added 🐛 bug Something isn't working confirmed This bug was confirmed labels Jul 4, 2022
@rluders rluders added this to the v1.0.0 milestone Jul 4, 2022
@tulup-conner tulup-conner self-assigned this Jul 30, 2022
@tulup-conner
Copy link
Collaborator

I found some tests are reporting false positive here. userEvent.focus(something) is not reliable. We should add Tooltip integration tests in cypress to actually cover user interactions like hover

tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jul 31, 2022
@tulup-conner
fix(component): display text only on Sidebar.Item tooltip
b44d784 
When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a
`Tooltip` with its text content. That isn't how it worked up until now.

resolve themesberg#258
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jul 31, 2022
@tulup-conner
fix(component): display text only on Sidebar.Item tooltip
c84afc5 
When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a
`Tooltip` with its text content. That isn't how it worked up until now.

resolve themesberg#258
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jul 31, 2022
@tulup-conner
fix(component): display text only on Sidebar.Item tooltip
1695af5 
When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a
`Tooltip` with its text content. That isn't how it worked up until now.

resolve themesberg#258
tulup-conner added a commit to tulup-conner/flowbite-react that referenced this issue Jul 31, 2022
@tulup-conner
fix(component): display text only on Sidebar.Item tooltip
39c8357 
When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a
`Tooltip` with its text content. That isn't how it worked up until now.

resolve themesberg#258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tulup-conner tulup-conner

Labels
🐛 bug Something isn't working confirmed This bug was confirmed
Projects
Flowbite React Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rluders @tulup-conner