fix(component): display text only on Sidebar.Item tooltip #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulup-conner
force-pushed
the
fix/sidebar-collapsed-hover
branch
from
f5d4dae
to
68760b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 99.13% 99.12% -0.01%
==========================================
Files 133 133
Lines 8276 8252 -24
Branches 955 947 -8
==========================================
- Hits 8204 8180 -24
Misses 72 72
Continue to review full report at Codecov.
|
tulup-conner
force-pushed
the
fix/sidebar-collapsed-hover
branch
from
68760b7
to
1d05f61
Compare
|
I've deliberately removed tests in this PR. These tests are unreliable. We should use cypress to test any hover interactions. |
When a `Sidebar` is collapsed, each item's text content is hidden. You hover over an item to see a `Tooltip` with its text content. That isn't how it worked up until now. resolve themesberg#258
I don't think we can rely on a fake DOM environment to test hover states correctly. We should write integration tests for `<Sidebar collapsed/>` behavior in `cypress`.
tulup-conner
force-pushed
the
fix/sidebar-collapsed-hover
branch
from
1d05f61
to
e665b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
None.
Bug fixes
Tests