Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to puppet/systemd #997

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Switch to puppet/systemd #997

merged 2 commits into from
Oct 21, 2021

Conversation

jovandeginste
Copy link
Contributor

No description provided.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the puppet/redis dependency to >= 8.0.0 for voxpupuli/puppet-redis@e439cd0#diff-12e598daecade60b04e493f45c134fec9287ac7471114d95d1995b4fb651a6c8.

We should also coordinate all modules so we don't break nightly so I'd prefer to have PRs for all modules.

@ekohl
Copy link
Member

ekohl commented Sep 21, 2021

This is also needs an update:

systemd:
repo: 'https://github.com/camptocamp/puppet-systemd'
ref: '2.12.0'

@ekohl
Copy link
Member

ekohl commented Sep 21, 2021

We should also coordinate all modules so we don't break nightly so I'd prefer to have PRs for all modules.

theforeman/puppet-dhcp#202 (comment)

@jovandeginste
Copy link
Contributor Author

This is also needs an update:

systemd:
repo: 'https://github.com/camptocamp/puppet-systemd'
ref: '2.12.0'

Like what I did now?

.fixtures.yml Outdated Show resolved Hide resolved
jovandeginste and others added 2 commits September 22, 2021 09:36
Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
@jovandeginste
Copy link
Contributor Author

2 tests fail (both on CentOS 8); the error is weird, which makes me believe it is unrelated to the PR. Is there a way to rerun a single test?

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tests fail (both on CentOS 8); the error is weird, which makes me believe it is unrelated to the PR.

I think so too

Is there a way to rerun a single test?

No, there isn't. I'm fine with merging this PR with those tests as red. I'm just going to make sure that all our PRs are ready to be merged before pressing the big green button.

@ekohl ekohl merged commit 4fc72e3 into theforeman:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants