Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on camptocamp/systemd ~> 3.1 #202

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Depend on camptocamp/systemd ~> 3.1 #202

merged 1 commit into from
Oct 21, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Sep 21, 2021

In 8ab95bc a change was made that required at least version 3.1.0. This fixes the metadata to reflect that.

@ekohl ekohl linked an issue Sep 21, 2021 that may be closed by this pull request
Use of notify_service requires systemd dependency version bump #201
Closed
@ekohl ekohl mentioned this pull request Sep 21, 2021
Closed
@evgeni
Copy link
Member

evgeni commented Sep 21, 2021

Technically, there is no such version.

https://forge.puppet.com/modules/camptocamp/systemd maxes out at 3.0.0, and newer ones are at https://forge.puppet.com/modules/puppet/systemd

Should we reflect that too?

@ekohl
Copy link
Member Author

ekohl commented Sep 21, 2021

I just came to the same conclusion. It'd be the right thing to do (and solve theforeman/puppet-puppet#802). Looking at our installer, only puppet/redis is outside of our namespace so it should be fairly easy to move.

@ekohl ekohl changed the title Raise minimum version of camptocamp/systemd to 3.1.0 Depend on camptocamp/systemd ~> 3.1 Sep 21, 2021
@ekohl ekohl force-pushed the fix-systemd-dep branch 2 times, most recently from 3f525b4 to bc6cc97 Compare September 21, 2021 10:12
@evgeni
Copy link
Member

evgeni commented Sep 21, 2021

Out of curiosity, what happens if we ask librarian to install camptocamp/systemd (via some dependency) and puppet/systemd?

evgeni
evgeni requested changes Sep 21, 2021
View reviewed changes
.fixtures.yml Outdated Show resolved Hide resolved
@ekohl
Depend on puppet/systemd ~> 3.1
955d058 
In 8ab95bc a change was made that
required at least version 3.1.0. That was only released under the puppet
namespace. This fixes the metadata to reflect that.

Fixes: 8ab95bc
@ekohl
Copy link
Member Author

ekohl commented Sep 21, 2021

We should coordinate merging these PRs in order not to break our nightly builds.

$ rg systemd _build/modules/*/metadata.json
_build/modules/systemd/metadata.json
2:  "name": "camptocamp-systemd",
7:  "source": "https://github.com/camptocamp/puppet-systemd",
8:  "project_page": "https://github.com/camptocamp/puppet-systemd",
9:  "issues_url": "https://github.com/camptocamp/puppet-systemd/issues",

_build/modules/redis/metadata.json
16:      "name": "camptocamp/systemd",

_build/modules/qpid/metadata.json
20:      "name": "camptocamp/systemd",

_build/modules/puppet/metadata.json
31:      "name": "camptocamp/systemd",

_build/modules/pulpcore/metadata.json
30:      "name": "camptocamp/systemd",

_build/modules/foreman/metadata.json
16:      "name": "camptocamp/systemd",

_build/modules/dhcp/metadata.json
19:      "name": "camptocamp/systemd",

@ekohl ekohl mentioned this pull request Sep 21, 2021
Merged
@ekohl
Copy link
Member Author

ekohl commented Sep 21, 2021

Out of curiosity, what happens if we ask librarian to install camptocamp/systemd (via some dependency) and puppet/systemd?

I think it should fail but I'm not sure tbh.

@jovandeginste
Copy link
Contributor

It picks one

@jovandeginste
Copy link
Contributor

If two modules disagree, librarian picks one; you can override by specifying it in your own Puppetfile. You should also "fix" the Puppetfile.lock

@ekohl ekohl merged commit 01c4c5c into theforeman:master Oct 21, 2021
@ekohl ekohl deleted the fix-systemd-dep branch October 21, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgeni evgeni evgeni requested changes

@ehelms ehelms ehelms approved these changes

Assignees
No one assigned
Labels
Enhancement Needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of notify_service requires systemd dependency version bump
5 participants
@ekohl @evgeni @jovandeginste @ehelms @theforeman-bot