metrics: add native histogram definitions to histograms #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add exponential bucket native histograms for objstore_bucket_operation_transferred_bytes objstore_bucket_operation_duration_seconds The resolution, maximum buckets, reset time can be changed later without migration as PromQL is able to handle those. For transferred bytes, the exponential buckets align perfectly with the previous exponential bucket definitions. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes: #107
Add exponential bucket native histograms for
objstore_bucket_operation_duration_secondsobjstore_bucket_operation_transferred_bytesThe resolution, maximum buckets, reset time can be changed later without migration as PromQL is able to handle those.
For transferred bytes, the exponential buckets align perfectly with the previous exponential bucket definitions.
Verification
Grafana Mimir depends on objstore, built Mimir from the PR branch and checked that the new metrics are scraped.
Metrics explorer:
Heatmap classic for
objstore_bucket_operation_duration_secondsHeatmap native for
objstore_bucket_operation_duration_secondsHeatmap classic for
objstore_bucket_operation_transferred_bytesHeatmap native for
objstore_bucket_operation_transferred_bytesMade with mimir@0d171f9f9e0643928c7e5b358d57ab6fa33e28d5 + patched objstore
Grafana v10.1.5 (849c612fcb). Using docker compose