Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native histogram version of objstore_bucket_operation_duration_seconds #107

Closed
krajorama opened this issue Mar 1, 2024 · 2 comments · Fixed by #108
Closed

Add native histogram version of objstore_bucket_operation_duration_seconds #107

krajorama opened this issue Mar 1, 2024 · 2 comments · Fixed by #108

Comments

@krajorama
Copy link
Contributor

krajorama commented Mar 1, 2024

I'd like to propose to add native histogram version of objstore_bucket_operation_duration_seconds so dependent projects can take advantage and migrate to native histograms. This would require bumping client_golang:

-       github.com/prometheus/client_golang v1.12.2
-       github.com/prometheus/common v0.36.0
+       github.com/prometheus/client_golang v1.17.0
+       github.com/prometheus/common v0.44.0

I can do the PR.

Out of scope: objstore_bucket_operation_transferred_bytes . Although that could be made into a native histogram with factor==2 (schema==0).

@fpetkovski
Copy link
Contributor

fpetkovski commented Mar 1, 2024

Let's do it, this nice upgrade has been long due 👍

What is the blocker for enabling native histograms for objstore_bucket_operation_transferred_bytes? We could limit the number of buckets if that's the concern.

@krajorama
Copy link
Contributor Author

Let's do it, this nice upgrade has been long due 👍

What is the blocker for enabling native histograms for objstore_bucket_operation_transferred_bytes? We could limit the number of buckets if that's the concern.

No blocker, I'm just trying to keep my scope in check, but then I'll do it as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants