Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Add min/max time flag configuration #213

Merged
merged 1 commit into from
Mar 22, 2021
Merged

store: Add min/max time flag configuration #213

merged 1 commit into from
Mar 22, 2021

Conversation

brancz
Copy link
Member

@brancz brancz commented Mar 22, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Add configuration options to configure --min-time and --max-time in the Thanos store.

Verification

Ran generate.

@kakkoyun @metalmatze

@brancz
store: Add min/max time flag configuration
0efc162 
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
kakkoyun
kakkoyun approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For the future: It'd be nice to have validators for the timestamp inputs, kube-thanos can benefit from those.

@brancz brancz merged commit 24ddf6a into thanos-io:main Mar 22, 2021
@brancz brancz deleted the min-max-time branch March 22, 2021 08:46
@craigfurman craigfurman mentioned this pull request Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brancz @kakkoyun