Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time based partitioning flags for the store #175

Closed
craigfurman opened this issue Nov 23, 2020 · 3 comments
Closed

Time based partitioning flags for the store #175

craigfurman opened this issue Nov 23, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@craigfurman
Copy link
Contributor

It'd be neat if we could pass config elements that map to the --max-time and --min-time thanos store flags, to implement time-based partitioning (https://thanos.io/tip/components/store.md/#time-based-partitioning). At the moment, I'm doing this by patching the jsonnet-generated statefulset to append to the container's args.

I'm happy to make a PR, if this is a feature the maintainers want.

@metalmatze
Copy link
Contributor

Glad to hear that the patching like that works for you, exactly why we want to use jsonnet.
I'm happy to get this into the project itself. Feel free to create a PR.

@craigfurman craigfurman mentioned this issue Jan 8, 2021
2 tasks
@craigfurman
Copy link
Contributor Author

Thanks @metalmatze. I've had a go at it, let me know what you think if you find time to review it: #187.

@kakkoyun kakkoyun added the enhancement New feature or request label Mar 5, 2021
@craigfurman
Copy link
Contributor Author

It looks like this was implemented in #213.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants