Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used OpenSSL correctly. #12

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Used OpenSSL correctly. #12

merged 5 commits into from
Oct 1, 2023

Conversation

tfpf
Copy link
Owner

@tfpf tfpf commented Sep 30, 2023

Closes #1.

CMake can detect OpenSSL while generating the build files. However, this also means that all programs must be linked against OpenSSL and HDRBG. That's not the direction I want to take this project in, so I probably won't merge this.

@tfpf tfpf added the enhancement New feature or request label Sep 30, 2023
@tfpf tfpf self-assigned this Sep 30, 2023
@tfpf tfpf marked this pull request as draft September 30, 2023 17:00
@tfpf tfpf marked this pull request as ready for review October 1, 2023 05:46
@tfpf
Copy link
Owner Author

tfpf commented Oct 1, 2023

I was wrong. If HDRBG is linked with OpenSSL, a program using HDRBG does not have to link with OpenSSL. (Linking with HDRBG is enough.)

@tfpf tfpf merged commit 31817eb into main Oct 1, 2023
6 checks passed
@tfpf tfpf deleted the ossl-proper branch October 1, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If OpenSSL is installed, it should possible to use its SHA-256 implementation.
1 participant