Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If OpenSSL is installed, it should possible to use its SHA-256 implementation. #1

Closed
tfpf opened this issue Jul 3, 2023 · 0 comments · Fixed by #12
Closed

If OpenSSL is installed, it should possible to use its SHA-256 implementation. #1

tfpf opened this issue Jul 3, 2023 · 0 comments · Fixed by #12
Assignees
Labels
enhancement New feature or request

Comments

@tfpf
Copy link
Owner

tfpf commented Jul 3, 2023

I observed that using the SHA-256 implementation of OpenSSL speeds up hdrbg_init and hdrbg_fill on Debian (WSL), Mint and Manjaro. On MSYS2, however, it slows them down!

Regardless, there should be an installation flag which allows users to choose which SHA-256 implementation they want to use. If they go for the OpenSSL implementation but it isn't available, it should fall back to my implementation.

(I have actually already made the required changes, but have moved them to another branch because pkg-config on MSYS2 does not correctly indicate whether OpenSSL is installed: pkg-config --libs openssl outputs -lssl -lcrypto even when openssl-devel is not installed, so linking the shared library fails. I should figure out a way to do this using CMake.)

@tfpf tfpf added the enhancement New feature or request label Jul 3, 2023
@tfpf tfpf self-assigned this Jul 3, 2023
@tfpf tfpf closed this as completed in #12 Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant