Complete bulk memory operations proposal #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok now intepreter passes bulk.wast spectest on my local machine.. other spectests are conflated with ref type proposal (notablely multi tables) so I will defer the complete spec test compatibility test to the ref type proposal impl later. I think that's enough for us to land this. will do the JIT impl and backfill unittests tomorrow |
mathetake
force-pushed
the
compleetebulkmemory
branch
from
13db89e to
e63cf3e
Compare
mathetake
changed the title
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
force-pushed
the
compleetebulkmemory
branch
from
e63cf3e to
5de256d
Compare
mathetake
commented
Apr 28, 2022
| bulkMemoryOperationsWasm []byte | ||
| // tableCopyWasm was compiled from testdata/table_copy.wat | ||
| //go:embed testdata/table_copy.wasm | ||
| tableCopyWasm []byte |
There was a problem hiding this comment.
note: these are derived from https://github.com/WebAssembly/spec/blob/9b4d86fbcd3309c3365c8430a4ac5ef2126c43a8/test/core/bulk.wast
codefromthecrypt
approved these changes
Apr 28, 2022
internal/integration_test/post1_0/bulk-memory-operations/testdata/elem_drop.wat
Show resolved
Hide resolved
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
ok resolved all comments! merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the rest of unimplemented instructions in the
bulk-memory-operations proposal.
Notably, this adds support for
table.init,table.copyandelem.dropinstructions toggled by FeatureBulkMemoryOperations.
Given that, now wazero has the complete support for bulk-memory-operations
proposal as described in https://github.com/WebAssembly/spec/blob/main/proposals/bulk-memory-operations/Overview.md
fixes #321