Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opt-in support for post 1.0 bulk-memory-operations #321

Closed
codefromthecrypt opened this issue Mar 3, 2022 · 2 comments · Fixed by #511
Closed

Add opt-in support for post 1.0 bulk-memory-operations #321

codefromthecrypt opened this issue Mar 3, 2022 · 2 comments · Fixed by #511

Comments

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Mar 3, 2022 •
edited
Loading

Looks like Grain defaults to use bulk-memory-operations, though this can be disabled with --no-bulk-memory per grain-lang/grain#819

Meanwhile, our crash isn't so pretty:

(41/323): invalid instruction 0xfc

cc @pims
@nullpo-head
Copy link
Contributor

For reference: Grain also requires #66.

@codefromthecrypt
Copy link
Contributor Author

This one is luckily not required by grain (as it can be controlled by a flag). Luckily, as it requires a fair amount of analysis to implement:

https://github.com/WebAssembly/spec/blob/main/proposals/bulk-memory-operations/Overview.md
WebAssembly/spec@7fa2f20

@codefromthecrypt codefromthecrypt mentioned this issue Mar 7, 2022
Closed
This was referenced Apr 25, 2022
Merged
Merged
Merged
mathetake added a commit that referenced this issue Apr 28, 2022
@mathetake
Complete bulk memory operations proposal (#511)
266320e 
This commit implements the rest of the unimplemented instructions in the
bulk-memory-operations proposal.

Notably, this adds support for table.init, table.copy and elem.drop
instructions toggled by FeatureBulkMemoryOperations.

Given that, now wazero has the complete support for the  bulk-memory-operations
proposal as described in https://github.com/WebAssembly/spec/blob/main/proposals/bulk-memory-operations/Overview.md

fixes #321

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete bulk memory operations proposal tetratelabs/wazero
2 participants
@codefromthecrypt @nullpo-head