Remove threads support

.github/workflows/spectest.yaml

@@ -35,7 +35,6 @@ jobs:
         spec-version:
           - "v1"
           - "v2"
-          - "threads"
 
     steps:
       - uses: actions/checkout@v3
@@ -62,7 +61,6 @@ jobs:
         spec-version:
           - "v1"
           - "v2"
-          - "threads"
 
     steps:
       - uses: actions/checkout@v3

Makefile

@@ -121,15 +121,11 @@ spectest_v2_dir := $(spectest_base_dir)/v2
 spectest_v2_testdata_dir := $(spectest_v2_dir)/testdata
 # Latest draft state as of Dec 16, 2022.
 spec_version_v2 := 1782235239ddebaf2cb079b00fdaa2d2c4dedba3
-spectest_threads_dir := $(spectest_base_dir)/threads
-spectest_threads_testdata_dir := $(spectest_threads_dir)/testdata
-spec_version_threads := cc01bf0d17ba3fb1dc59fb7c5c725838aff18b50
 
 .PHONY: build.spectest
 build.spectest:
 	@$(MAKE) build.spectest.v1
 	@$(MAKE) build.spectest.v2
-	@$(MAKE) build.spectest.threads
 
 .PHONY: build.spectest.v1
 build.spectest.v1: # Note: wabt by default uses >1.0 features, so wast2json flags might drift as they include more. See WebAssembly/wabt#1878
@@ -169,21 +165,9 @@ build.spectest.v2: # Note: SIMD cases are placed in the "simd" subdirectory.
 		wast2json --debug-names $$f; \
 	done
 
-.PHONY: build.spectest.threads
-build.spectest.threads:
-	@mkdir -p $(spectest_threads_testdata_dir)
-	@cd $(spectest_threads_testdata_dir) \
-		&& curl -sSL 'https://api.github.com/repos/WebAssembly/threads/contents/test/core?ref=$(spec_version_threads)' | jq -r '.[]| .download_url' | grep -E "atomic.wast" | xargs -Iurl curl -sJL url -O
-# Fix broken CAS spectests
-# https://github.com/WebAssembly/threads/issues/195#issuecomment-1318429506
-	@cd $(spectest_threads_testdata_dir) && patch < ../atomic.wast.patch
-	@cd $(spectest_threads_testdata_dir) && for f in `find . -name '*.wast'`; do \
-		wast2json --enable-threads --debug-names $$f; \
-	done
-
 .PHONY: test
 test:
-	@go test $(go_test_options) $$(go list ./... | grep -vE '$(spectest_v1_dir)|$(spectest_v2_dir)|$(spectest_threads_dir)')
+	@go test $(go_test_options) $$(go list ./... | grep -vE '$(spectest_v1_dir)|$(spectest_v2_dir)')
 	@cd internal/version/testdata && go test $(go_test_options) ./...
 
 .PHONY: coverage
@@ -197,17 +181,13 @@ coverage: ## Generate test coverage
 spectest:
 	@$(MAKE) spectest.v1
 	@$(MAKE) spectest.v2
-	@$(MAKE) spectest.threads
 
 spectest.v1:
 	@go test $(go_test_options) $$(go list ./... | grep $(spectest_v1_dir))
 
 spectest.v2:
 	@go test $(go_test_options) $$(go list ./... | grep $(spectest_v2_dir))
 
-spectest.threads:
-	@go test $(go_test_options) $$(go list ./... | grep $(spectest_threads_dir))
-
 golangci_lint_path := $(shell go env GOPATH)/bin/golangci-lint
 
 $(golangci_lint_path):

api/features.go

@@ -143,8 +143,6 @@ const (
 	// Note: The instruction list is too long to enumerate in godoc.
 	// See https://github.com/WebAssembly/spec/blob/wg-2.0.draft1/proposals/simd/SIMD.md
 	CoreFeatureSIMD
-
-	// Update experimental/features.go when adding elements here.
 )
 
 // SetEnabled enables or disables the feature or group of features.
@@ -209,9 +207,6 @@ func featureName(f CoreFeatures) string {
 	case CoreFeatureSIMD:
 		// match https://github.com/WebAssembly/spec/blob/wg-2.0.draft1/proposals/simd/SIMD.md
 		return "simd"
-	case CoreFeatureSIMD << 1: // Defined in experimental/features.go
-		// match https://github.com/WebAssembly/threads/blob/main/proposals/threads/Overview.md
-		return "threads"
 	}
 	return ""
 }