Remove threads support #1487
Merged
Remove threads support #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
considering the state of the threads proposal and the mosquito-bites of broken builds, hacks, and other cognitive load on various devs since this was merged... I'm wondering if it we aren't digging a hole. Could it be better to revert it and try again later when things normalize? WebAssembly/threads#198 |
|
Sure I think that makes sense too |
|
At least the state makes me feel like we should put on hold the implementation on compiler backend at least until it reaches the phrase 4. |
|
thanks folks. I think we learned a lot and will be better off on the redo. @anuraaga do you want to raise the revert (or re-purpose this one?) |
This reverts commit 90eba1b. Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
…atelabs#1460)" This reverts commit bc96257. Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
anuraaga
changed the title
|
Sure, repurposed this PR |
codefromthecrypt
approved these changes
May 22, 2023
Closed
anuraaga
added a commit
to anuraaga/wazero
that referenced
this pull request
Sep 4, 2023
This reverts commit 714368b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec is still not in a great state