Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing env var INFLUXDB_URL #1487

Merged
merged 3 commits into from
Dec 1, 2022
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/runner/local_docker.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ func (r *LocalDockerRunner) Healthcheck(ctx context.Context, engine api.Engine,
Entrypoint: []string{"testground"},
Cmd: []string{"sidecar", "--runner", "docker"},
// NOTE: we export REDIS_HOST for compatibility with older sdk versions.
Env: []string{"SYNC_SERVICE_HOST=testground-sync-service", "REDIS_HOST=testground-redis", "INFLUXDB_HOST=testground-influxdb", "GODEBUG=gctrace=1", additionalHosts},
Env: []string{"SYNC_SERVICE_HOST=testground-sync-service", "REDIS_HOST=testground-redis", "INFLUXDB_HOST=testground-influxdb", "INFLUXDB_URL=http://testground-influxdb:8086", "GODEBUG=gctrace=1", additionalHosts},
},
HostConfig: &container.HostConfig{
PublishAllPorts: true,
Expand Down Expand Up @@ -739,7 +739,7 @@ func attachContainerToNetwork(ctx context.Context, cli *client.Client, container
return cli.NetworkConnect(ctx, networkID, containerID, nil)
}

//nolint this function is unused, but it may come in handy.
// nolint this function is unused, but it may come in handy.
func detachContainerFromNetwork(ctx context.Context, cli *client.Client, containerID string, networkID string) error {
ctx, cancel := context.WithTimeout(ctx, 10*time.Second)
defer cancel()
Expand Down