fix: missing env var INFLUXDB_URL #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ackintosh thanks for sharing! Could you rebase on the latest master? I'll trigger another CI run and make sure we review this soon. |
The sidecar shows the warning message on console: MESSAGE << sidecar >> InfluxDB unavailable; no metrics will be dispatched: no InfluxDB URL in $INFLUXDB_URL env var
|
I have rebased this on the latest master branch. 😃 |
|
I was holding it wrong, patch works :) Got some metrics in :) |
|
can we merge this please? Move the bytes working group is already relying on this patch |
nonsense
approved these changes
Nov 20, 2022
laurentsenta
approved these changes
Dec 1, 2022
|
Merged, thanks for the fix @ackintosh ! And thanks for the heads up @b5 , @Arqu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1428.