Feature/455 Added WithNetworkAliases functionality

[vlaskal]

This PR should bring new functionality WithNetworkAliases to ITestcontainersBuilder<>

    /// <summary>
    /// Assign specified network aliases to container.
    /// </summary>
    /// <param name="networkAliases">Set of network aliases.</param>
    /// <returns>A configured instance of <see cref="ITestcontainersBuilder{TDockerContainer}" />.</returns>
    [PublicAPI]
    ITestcontainersBuilder<TDockerContainer> WithNetworkAliases(params string[] networkAliases);

    /// <summary>
    /// Assign specified network aliases to container.
    /// </summary>
    /// <param name="networkAliases">Set of network aliases.</param>
    /// <returns>A configured instance of <see cref="ITestcontainersBuilder{TDockerContainer}" />.</returns>
    [PublicAPI]
    ITestcontainersBuilder<TDockerContainer> WithNetworkAliases(IEnumerable<string> networkAliases);

[HofmeisterAn]

Thanks for your contribution. I can do the review in the next days. Today I’m busy.

[HofmeisterAn]

Probably I expressed myself unclear. What I meant is, that you can use a similar or the same approach to test your changes, like TestcontainersNetworkTest and NetworkFixture does.

You can revert the changes in TestcontainersNetworkTest and NetworkFixture and replace it with something like:

diff --git a/tests/Testcontainers.Tests/Unit/Networks/TestcontainersNetworkTest.cs b/tests/Testcontainers.Tests/Unit/Networks/TestcontainersNetworkTest.cs
index 01a0e26..b5cb7aa 100644
--- a/tests/Testcontainers.Tests/Unit/Networks/TestcontainersNetworkTest.cs
+++ b/tests/Testcontainers.Tests/Unit/Networks/TestcontainersNetworkTest.cs
@@ -9,6 +9,8 @@ namespace DotNet.Testcontainers.Tests.Unit
   [Collection(nameof(Testcontainers))]
   public sealed class TestcontainersNetworkTest : IClassFixture<NetworkFixture>, IAsyncLifetime
   {
+    private const string Alias = "-alias";
+
     private readonly ITestcontainersContainer testcontainer1;
 
     private readonly ITestcontainersContainer testcontainer2;
@@ -22,10 +24,12 @@ namespace DotNet.Testcontainers.Tests.Unit
 
       this.testcontainer1 = testcontainersBuilder
         .WithHostname(nameof(this.testcontainer1))
+        .WithNetworkAliases(nameof(this.testcontainer1) + Alias)
         .Build();
 
       this.testcontainer2 = testcontainersBuilder
         .WithHostname(nameof(this.testcontainer2))
+        .WithNetworkAliases(nameof(this.testcontainer2) + Alias)
         .Build();
     }
 
@@ -39,10 +43,14 @@ namespace DotNet.Testcontainers.Tests.Unit
       return Task.WhenAll(this.testcontainer1.DisposeAsync().AsTask(), this.testcontainer2.DisposeAsync().AsTask());
     }
 
-    [Fact]
-    public async Task PingContainer()
+    [Theory]
+    [InlineData(nameof(testcontainer2))]
+    [InlineData(nameof(testcontainer2) + Alias)]
+    public async Task Ping(string destination)
     {
-      Assert.Equal(0, (await this.testcontainer1.ExecAsync(new[] { "ping", "-c", "4", nameof(this.testcontainer2) })).ExitCode);
+      var execResult = await this.testcontainer1.ExecAsync(new[] { "ping", "-c", "4", destination })
+        .ConfigureAwait(false);
+      Assert.Equal(0, execResult.ExitCode);
     }
   }
 }

If you know how it works, it would be nice if you squash your commits to a single commit.

[vlaskal]

You can revert the changes in TestcontainersNetworkTest and NetworkFixture and replace it with something like:

Updated - nice design

[vlaskal]

If you know how it works, it would be nice if you squash your commits to a single commit.

Squashed as you wanted

[HofmeisterAn]

Published in 2.0.0, closes #455.