Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function WithNetworkAliases #455

Closed
vlaskal opened this issue May 13, 2022 · 5 comments
Closed

Add missing function WithNetworkAliases #455

vlaskal opened this issue May 13, 2022 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@vlaskal
Copy link
Contributor

vlaskal commented May 13, 2022

Is your feature request related to a problem? Please describe.
I have application which behaves differently based on url eg. branding.
I would like to test this application deployed in docker, that branding switching works correctly.

Describe the solution you'd like
I'd like to define several aliases for my container as Docker CLI option --network-alias does.
Also this function is available in Java version of testcontainers.

Describe alternatives you've considered
I tried to look around for other libraries and found just one. The reason why I would like to see this function is similarity with Java version.

Additional context
I think this is basic functionality which is missing.

Let me know what you think about this request.
I can help with it in case.

@HofmeisterAn
Copy link
Collaborator

Sounds good 👍 I just can't take care of it right now. Would you like to contribute and work on it?

@HofmeisterAn HofmeisterAn added the enhancement New feature or request label May 13, 2022
@vlaskal
Copy link
Contributor Author

vlaskal commented May 13, 2022

Cool, I can try. This is not a problem for me.

Unfortunatelly I have Rancher desktop which cause me problem and error which is described here #431 but is caused by dotnet/Docker.DotNet#554.
Can take a time to solve main problem or do you have any other idea how to overcome this error?

@HofmeisterAn
Copy link
Collaborator

I haven't had any time to take a look into this issue, sorry. Usually, I use Docker Desktop or Docker Enterprise Edition. Maybe I'll have some time, beginning of next month. It would be nice to support Rancher Desktop as well. Is only CopyOutputToAsync broken?

@vlaskal
Copy link
Contributor Author

vlaskal commented May 13, 2022

Yes, support Rancher Desktop will open new areas which was cut by Docker Desktop license.
For me it fails in StartAsync method when client wants to attach to container Task<MultiplexedStream> AttachContainerAsync(...) . I think it is not Rancher Desktop problem but more less of Moby version.
I will look at it and in case I will jump to Docker Desktop for a while and will add WithNetworkAliases function.

@HofmeisterAn HofmeisterAn added the help wanted Extra attention is needed label Jun 4, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 16, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 16, 2022
@vlaskal
Copy link
Contributor Author

vlaskal commented Jun 17, 2022

@HofmeisterAn I tried to create first PR #480 for this feature and also first in this repo. I hope I did everything correctly.

HofmeisterAn pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 18, 2022
HofmeisterAn pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 18, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 20, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 20, 2022
vlaskal pushed a commit to vlaskal/dotnet-testcontainers that referenced this issue Jun 20, 2022
@HofmeisterAn HofmeisterAn added this to the 1.7.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants