Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation/Code Coverage CI Update #876

Merged
merged 22 commits into from
Apr 8, 2023

Conversation

marip8
Copy link
Contributor

@marip8 marip8 commented Apr 3, 2023

I think this should fully address #867. I think we should see a code coverage post to this PR if it works correctly

@Levi-Armstrong
Copy link
Contributor

It looks like it found the reports but failed to upload them.

@Levi-Armstrong
Copy link
Contributor

I just restarted codecov build to see if anything changes with the upload.

@marip8
Copy link
Contributor Author

marip8 commented Apr 4, 2023

I encountered the same issues while testing locally. Do we just need to regenerate the code-cov token? Also should that be a repository secret? The code-cov quick start guide seems to suggest that

@Levi-Armstrong
Copy link
Contributor

Yea, probably. Do you have access?

@Levi-Armstrong
Copy link
Contributor

Levi-Armstrong commented Apr 4, 2023

@marip8 It looks like it cannot find the token variable.

@Levi-Armstrong
Copy link
Contributor

@marip8 You have any ideas how to get this to work?

@Levi-Armstrong
Copy link
Contributor

@marip8 The issues is that codecov needs to be ran from within the tesseract repos directory because that is where the codecov.yaml file is located.

before:

AFTER_SCRIPT: catkin build -w $target_ws --no-deps tesseract_collision tesseract_common tesseract_environment tesseract_geometry tesseract_kinematics tesseract_srdf tesseract_state_solver tesseract_scene_graph tesseract_urdf --make-args ccov-all && bash <(curl -s https://codecov.io/bash) -t c4af0da7-9fc3-4d3c-bb2e-6b2523ddd382 -s $target_ws/build -f *all-merged.info

@Levi-Armstrong
Copy link
Contributor

I think I am down to the remaining issue. The current upload request is missing things like branch, commit, etc.

Original upload request

2023-03-09T05:46:50.0552648Z https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=c4af0da7-9fc3-4d3c-bb2e-6b2523ddd382&branch=master&commit=4f04a9191aea239f38fbef8fce9ce457d46b0d15&build=&build_url=&name=&tag=&slug=tesseract-robotics%2Ftesseract&service=&flags=&pr=&job=&cmd_args=t,s,f
2023-03-09T05:46:50.0553340Z �[0;90m->�[0m  Uploading to

Current upload request

2023-04-08T20:30:00.5487018Z https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=758610a6-d851-4185-a01a-5b9465889b62&branch=&commit=&build=&build_url=&name=&tag=&slug=&service=&flags=&pr=&job=&cmd_args=t,s,f
2023-04-08T20:30:00.5487605Z �[0;31mInvalid request parameters

@Levi-Armstrong
Copy link
Contributor

@marip8 I worked through all of the issues and it now uploading. Take a look at the after script, but I was unable to figure out how to leverage the secrets token, but I will merge this and we can figure that out later.

@Levi-Armstrong Levi-Armstrong merged commit 176d21d into tesseract-robotics:master Apr 8, 2023
@marip8 marip8 deleted the update/codecov-ci branch April 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants