Remove swap parameter and related code #706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Remove all code for auto detection of endianness used in data files. This prepares the switch to data files with fixed endianness. Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
@theraysmith, this PR is ready to get pulled as soon as there is a decision to switch to fixed endianness (little endian) for the training data files. |
theraysmith
reviewed
Feb 7, 2017
| if (swap) { | ||
| ReverseN(&size1, sizeof(size1)); | ||
| ReverseN(&size2, sizeof(size2)); | ||
| } | ||
| Resize(size1, size2, empty_); |
There was a problem hiding this comment.
There is a malloc failure and a crash right here if you don't reverse the size to be allocated!
|
Rejected. I don't see how this can possibly work. |
|
I'm afraid there is a misunderstanding. This patch does not implement big endian support. It removes the current effort to support big endian as a first step for a different implementation which I think is more promising. PR #703 mixes removing the current implementation and implementing a new one and should be rebased on PR #706. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code for auto detection of endianness used in data files.
This prepares the switch to data files with fixed endianness.
Signed-off-by: Stefan Weil sw@weilnetz.de