Add experimental support for big endian hosts (read part only) #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorpugin
reviewed
Feb 5, 2017
| @@ -69,6 +72,19 @@ class TFile { | |||
| char* FGets(char* buffer, int buffer_size); | |||
| // Replicates fread, returning the number of items read. | |||
| int FRead(void* buffer, int size, int count); | |||
| int FRead(char* buffer, unsigned count); | |||
There was a problem hiding this comment.
Is it possible to implement this using templates?
egorpugin
reviewed
Feb 5, 2017
| } | ||
| #else | ||
|
|
||
| bool fread(uint8_t* data, FILE* f, size_t n = 1); |
|
Yes, I think it would be possible to use templates in both cases. I did not do that because I wanted to see which cases occur in practice. Some of those cases are problematic, because they don't use portable data types: the current code reads and writes |
Signed-off-by: Stefan Weil <sw@weilnetz.de>
This commit adds hacks to enforce more debug messages. Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: root <root@bib.uni-mannheim.de>
Signed-off-by: Stefan Weil <sw@weilnetz.de>
This was referenced Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for getting pulled. I put it here only for further discussion. See also issue #518.
Writing training data on big endian machines is currently not addressed.