-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
which versions of leptonica are being enforced; release version vs. SO version #540
Comments
Also see #536 |
https://github.com/tesseract-ocr/tesseract/wiki/Compiling There is a pending patch from Jeff that will need 1.74. Anyway, the two build system should be updated. |
Not 100% sure, but I think I already have a requirement on 1.73 to support PDF generation. |
We now depend on 1.74.0 (see commit 11f2057) |
That is pretty aggressive. Hope the multipage TIFF users appreciate it.
…On Dec 24, 2016 11:10 PM, "Amit D." ***@***.***> wrote:
Since commit 11f2057
<11f2057>
we depend on 1.74.0
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#540 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEu2ppN95ut9tOVVOanEd-g9HWJuJB6Dks5rLhbXgaJpZM4LGDsQ>
.
|
If you want to support 1.73 you can provide a patch... :-) |
I mean, the code will still use your patch for 1.74 but will fallback to the previous behaviour for 1.73. |
I thought that with 1.74, and SO 5.1, there is no longer a need for that tiff patch on debian. btw, github release 1.74.0 is now also up as 1.74 (in the usual configure-make tarball) on leptonica.org: |
Jeff, |
1.73 has O (n^3) for seeks on multi page TIFF. 1.74 drops that to O(n^2)
for the existing API and O(n) for some new API calls.
I have never made a PPA before and am not sure what is involved. Priority
is official Leptonica packaging. Unclear if l will even get that far before
the new year, due to travel.
So the answer is maybe, but I wasn't planning on it, and certainly not
right now.
…On Dec 25, 2016 11:57 AM, "Amit D." ***@***.***> wrote:
Jeff,
Any chance you will provide a Leptonica 1.74 PPA for Ubuntu 16.04?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#540 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEu2pj7OCq7Ics1Saik6-5_FHHfRaFm7ks5rLsrCgaJpZM4LGDsQ>
.
|
OK, I thought that you are familiar with PPAs. I didn't mean to push you to prepare a PPA. |
Jeff made a Leponica 1.74.1 package for Debian: |
Unofficial Ubuntu PPAs for Tesseract 4.00 & Leptonica 1.74: |
There are still numerous platforms without prebuild Leptonica 1.74.x. I just suggested updating the version for MacPorts. Maybe fallback code which is slower for multi page tiffs but which works with older Leptonica versions would really be a good idea. |
I'm totally fine with any decision, including reverting the new TIFF calls until Leptonica 1.74 is more widespread. This was the changelist. |
Current CMakeLists.txt:
|
This issue can be closed. |
We're in the process of updating leptonica to version 1.74.0.
This will go out with debian with SO version 5.1.0.
I see in CMakeLists.txt:
set(MINIMUM_LEPTONICA_VERSION 1.71)
Two questions:
(1) Should this be increased? 1.71 is at least 2 years old, likely still binary compatible.
(2) With autotools, the SO version defines the binary interface compatibility, which is why we're bumping it up from 5.0.0 in 1.73 to 5.1.0 in 1.74. Does cmake use the SO version?
The text was updated successfully, but these errors were encountered: