Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which versions of leptonica are being enforced; release version vs. SO version #540

Closed
DanBloomberg opened this issue Dec 7, 2016 · 17 comments

Comments

@DanBloomberg
Copy link

We're in the process of updating leptonica to version 1.74.0.

This will go out with debian with SO version 5.1.0.

I see in CMakeLists.txt:
set(MINIMUM_LEPTONICA_VERSION 1.71)

Two questions:
(1) Should this be increased? 1.71 is at least 2 years old, likely still binary compatible.

(2) With autotools, the SO version defines the binary interface compatibility, which is why we're bumping it up from 5.0.0 in 1.73 to 5.1.0 in 1.74. Does cmake use the SO version?

@Shreeshrii
Copy link
Collaborator

Also see #536

@amitdo
Copy link
Collaborator

amitdo commented Dec 7, 2016

https://github.com/tesseract-ocr/tesseract/wiki/Compiling
Ray added the 1.73 requirement for 4.0.

There is a pending patch from Jeff that will need 1.74.
#233 (comment)

Anyway, the two build system should be updated.

@jbreiden
Copy link
Contributor

jbreiden commented Dec 7, 2016

Not 100% sure, but I think I already have a requirement on 1.73 to support PDF generation.

@amitdo
Copy link
Collaborator

amitdo commented Dec 25, 2016

We now depend on 1.74.0 (see commit 11f2057)

@jbreiden
Copy link
Contributor

jbreiden commented Dec 25, 2016 via email

@amitdo
Copy link
Collaborator

amitdo commented Dec 25, 2016

If you want to support 1.73 you can provide a patch... :-)

@amitdo
Copy link
Collaborator

amitdo commented Dec 25, 2016

I mean, the code will still use your patch for 1.74 but will fallback to the previous behaviour for 1.73.

@DanBloomberg
Copy link
Author

I thought that with 1.74, and SO 5.1, there is no longer a need for that tiff patch on debian.

btw, github release 1.74.0 is now also up as 1.74 (in the usual configure-make tarball) on leptonica.org:
leptonica.org/source/leptonica-1.74.tar.gz

@amitdo
Copy link
Collaborator

amitdo commented Dec 25, 2016

Jeff,
Any chance you will provide a Leptonica 1.74 PPA for Ubuntu 16.04?

@jbreiden
Copy link
Contributor

jbreiden commented Dec 25, 2016 via email

@amitdo
Copy link
Collaborator

amitdo commented Dec 26, 2016

OK, I thought that you are familiar with PPAs. I didn't mean to push you to prepare a PPA.

@amitdo
Copy link
Collaborator

amitdo commented Jan 5, 2017

Jeff made a Leponica 1.74.1 package for Debian:
https://packages.debian.org/sid/libleptonica-dev

@amitdo
Copy link
Collaborator

amitdo commented Jan 16, 2017

Unofficial Ubuntu PPAs for Tesseract 4.00 & Leptonica 1.74:
https://launchpad.net/~alex-p/+archive/ubuntu/tesseract-ocr

@stweil
Copy link
Member

stweil commented Jan 23, 2017

There are still numerous platforms without prebuild Leptonica 1.74.x. I just suggested updating the version for MacPorts. Maybe fallback code which is slower for multi page tiffs but which works with older Leptonica versions would really be a good idea.

@jbreiden
Copy link
Contributor

I'm totally fine with any decision, including reverting the new TIFF calls until Leptonica 1.74 is more widespread. This was the changelist.

245eebd

@amitdo
Copy link
Collaborator

amitdo commented Feb 24, 2018

Current CMakeLists.txt:

set(MINIMUM_LEPTONICA_VERSION 1.74)

@amitdo
Copy link
Collaborator

amitdo commented Feb 24, 2018

This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants