Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leptonica: Update to version 1.74.1 #180

Closed
wants to merge 1 commit into from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Jan 23, 2017

This also involves switching to releases from GitHub.
Fix also a typo in the description.

Signed-off-by: Stefan Weil sw@weilnetz.de

This also involves switching to releases from GitHub.
Fix also a typo in the description.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@tobypeterson
Copy link
Contributor

Why is this pulling from github? This version seems to be available on http://www.leptonica.com/download.html

Presumably that also won't require rerunning all the autotools, too.

@stweil
Copy link
Contributor Author

stweil commented Jan 27, 2017

That's correct. I had chosen GitHub because Leptonica switched to GitHub, so that is the primary source now, but as you noticed, Dan is still providing tagged versions on the Leptonica website. I don't mind if you drop my PR. The important thing is the new version.
PS. There remains still the typo in the description. :-)

@tobypeterson
Copy link
Contributor

This PR is good, but I think you could simplify things by using the source from the website. It's already been autotooled, so you can probably avoid adding the autoreconf step and all those build dependencies. So it'd be a much more standard update.

@tobypeterson
Copy link
Contributor

Closing - simple update done in 5906831

@stweil stweil deleted the leptonica branch January 30, 2017 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants