Removing unused method arguments #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opotowsky
approved these changes
Jul 6, 2022
keckler
approved these changes
Jul 6, 2022
| @@ -938,12 +938,12 @@ class TestHelix(TestShapedComponent): | |||
| "id": 0.1, | |||
| } | |||
|
|
|||
| def test_getBoundingCircleOuterDiameter(self, Tc=None, cold=False): | |||
| def test_getBoundingCircleOuterDiameter(self): | |||
There was a problem hiding this comment.
Good catch.
This went through the review of #747 yesterday without any notice!
| """ | ||
| pass | ||
|
|
||
|
|
There was a problem hiding this comment.
This function is just egregious. How did this get in here??
There was a problem hiding this comment.
I can't tell. It had been there for three years.
I know clean up PRs aren't sexy, but man, sometimes they are necessary.
opotowsky
added a commit
that referenced
this pull request
Oct 7, 2022
opotowsky
added a commit
that referenced
this pull request
Oct 10, 2022
…tional arguments (#922) * Update the entry point class to provide the settings file as an required position argument when a user requests the help menu. Additionally, add a try/except around adding a new argument from case settings to handle duplicate entries more robustly rather than requiring exclusion of settings like `verbosity` and `branchVerbosity`. * Suppress the printing of all possible settings in clone CLI * There are 18 entry points! * Make changes to checkInputs CLI and tests Having both a settings file and patterns arg is both redundant and causes unreliable use issues. Since only patterns was used in invoke, decided to remove the settingsArgument as optional. I also removed the sys.exit(), since there is no need that I can think of to do this. The armi unit test settings file, e.g., fails this check (with can start = UNKNOWN). * Move settings arg processing to not be first (nargs='*' behavior means this can't be first in the list) * Minor docstring add * Remove reloadDBName setting from armiRun.yaml This is only needed for 3 tests, and it was causing some annoying failures on the check-inputs entry point test (although I fixed it separately by rejecting the notion that there needed to be a sys.exit()). * Update warning to error for checkInputs CLI * Remove unused CLI args from checkInputs (finishing what #754 started) * Remove update to real file because that ain't necessary * Release Notes Co-authored-by: Arrielle Opotowsky <c-aopotowsky@terrapower.com>
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
scottyak
pushed a commit
to scottyak/armi
that referenced
this pull request
Oct 27, 2022
…tional arguments (terrapower#922) * Update the entry point class to provide the settings file as an required position argument when a user requests the help menu. Additionally, add a try/except around adding a new argument from case settings to handle duplicate entries more robustly rather than requiring exclusion of settings like `verbosity` and `branchVerbosity`. * Suppress the printing of all possible settings in clone CLI * There are 18 entry points! * Make changes to checkInputs CLI and tests Having both a settings file and patterns arg is both redundant and causes unreliable use issues. Since only patterns was used in invoke, decided to remove the settingsArgument as optional. I also removed the sys.exit(), since there is no need that I can think of to do this. The armi unit test settings file, e.g., fails this check (with can start = UNKNOWN). * Move settings arg processing to not be first (nargs='*' behavior means this can't be first in the list) * Minor docstring add * Remove reloadDBName setting from armiRun.yaml This is only needed for 3 tests, and it was causing some annoying failures on the check-inputs entry point test (although I fixed it separately by rejecting the notion that there needed to be a sys.exit()). * Update warning to error for checkInputs CLI * Remove unused CLI args from checkInputs (finishing what terrapower#754 started) * Remove update to real file because that ain't necessary * Release Notes Co-authored-by: Arrielle Opotowsky <c-aopotowsky@terrapower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@keckler recently opened a ticket for an unused method argument. Well, we fixed his method, but I thought I should do a quick cull through the rest of the repo to see if I could find other methods with unused arguments, and fix those as well.
Checklist