Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update helix docstrings + bug fix #747

Merged
merged 3 commits into from
Jul 5, 2022
Merged

update helix docstrings + bug fix #747

merged 3 commits into from
Jul 5, 2022

Conversation

albeanth
Copy link
Member

@albeanth albeanth commented Jul 5, 2022

  • docstrings expanded upon to improve clarity
  • bug fix in getCircleInnerDiameter
  • getCircleOuterDiameter adjusted for consistency with getCircleInnerDiameter

Checklist

  • The code is understandable and maintainable to people beyond the author.
  • Tests have been added/updated to verify that the new or changed code works.
  • There is no commented out code in this PR.
  • The commit message follows good practices.
  • All docstrings are still up-to-date with these changes.

@albeanth
update helix docstrings + bug fix
f67d127 
- docstrings expanded upon for helix to improve clarity
- bug fix in `getCircleInnerDiameter`
- `getCircleOuterDiameter` adjusted for consistency with `getCircleInnerDiameter`
onufer
onufer requested changes Jul 5, 2022
View reviewed changes
armi/reactor/components/complexShapes.py Show resolved Hide resolved
armi/reactor/components/complexShapes.py Outdated Show resolved Hide resolved
armi/reactor/components/complexShapes.py Outdated Show resolved Hide resolved
@john-science john-science merged commit d04e1be into terrapower:main Jul 5, 2022
@keckler keckler mentioned this pull request Jul 6, 2022
Merged
5 tasks
@albeanth albeanth mentioned this pull request Jul 21, 2022
Merged
7 tasks
@albeanth albeanth deleted the clarifyHelixComponent branch August 3, 2022 22:52
scottyak pushed a commit to scottyak/armi that referenced this pull request Oct 27, 2022
@albeanth @scottyak
Updating helix docstrings + bug fix (terrapower#747)
731a231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onufer onufer onufer approved these changes

@john-science john-science john-science approved these changes

@ntouran ntouran Awaiting requested review from ntouran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albeanth @john-science @onufer