Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in invalid xsTypeNum condition #2042

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Raise error in invalid xsTypeNum condition #2042

merged 3 commits into from
Jan 3, 2025

Conversation

ntouran
Copy link
Member

@ntouran ntouran commented Jan 1, 2025 •
edited by john-science
Loading

What is the change?

Add error and fix invalid test fixture data that was triggering a warning.

Why is the change being made?

It was mentioned in #2041 as causing warnings during tests. Invalid input data should lead to errors.

Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@ntouran
Raise error in invalid xsTypeNum condition
b3c6742 
Also fix invalid test fixture data that was triggering
a warning.

Part of terrapower#2041
@john-science
Copy link
Member

Some test failures here.

@john-science john-science added the enhancement New feature or request label Jan 2, 2025
@john-science
Copy link
Member

Just to be safe, I am running a downstream test suite.

@john-science
Copy link
Member

Okay, downstream tests passed. We're good.

@john-science john-science self-requested a review January 3, 2025 16:19
john-science
john-science approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@john-science john-science merged commit ea73f1c into terrapower:main Jan 3, 2025
13 checks passed
@ntouran ntouran deleted the ntouran/fix-xs-int branch January 6, 2025 15:12
drewj-tp added a commit that referenced this pull request Jan 10, 2025
@drewj-tp
Merge remote-tracking branch 'origin/main' into drewj/composite-iter/…
a6e803b 
…1915

* origin/main:
  Unpinning the max `matplotlib` version (#2040)
  Raising error in invalid xsTypeNum condition (#2042)
  Starting the armi.testing modules (#2028)
  Sorting imports with ruff (#2025)
  Identifying all first-order dependencies (#2039)
  Removing dependence on six (#2037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-science john-science john-science approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntouran @john-science