-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin the max matplotlib
version, which upgrades numpy
#2040
Conversation
Okay, I see broken tests. But I like the IDEA of the PR, and am happy to support it in whatever way you need. |
Yep I'm just playing around trying to find a set of deps that works with the unpinned matplotlib for higher python versions. Right now py39 and py310 are failing, as expected. I have to find the place in the code responsible for returning the |
matplotlib
versionmatplotlib
version, which upgrades numpy
@john-science This is ready now! let me know if it's important enough for the release notes. I guessed "no" but I'm willing to be wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks so much!
What is the change?
TL;DR: fixed some numpy and python deprecation issues, and deleted the max
matplotlib
pin for py311 and up.Unpinning the max
matplotlib
pin in ARMI opened some floodgates for other upgrades, specificallynumpy
. I ended up with one test failing intest_historyTracker.py
because some zeroes were being saved asnp.int64
in the database and that was getting processed into strings when usinggetHistory
. So that's where those forcedint()
pieces came from. The rest is self explanatory numpy deprecation warnings.Why is the change being made?
matplotlib
v3.8 being the max version doesn't always work with higher python versions. The pip resolution in github actions is not behaving the same elsewhere. So let's just fix root cause of the max pin instead.Checklist
doc
folder.pyproject.toml
.