Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin the max matplotlib version, which upgrades numpy #2040

Merged
merged 17 commits into from
Jan 3, 2025
Merged

Conversation

opotowsky
Copy link
Member

@opotowsky opotowsky commented Dec 28, 2024

What is the change?

TL;DR: fixed some numpy and python deprecation issues, and deleted the max matplotlib pin for py311 and up.

Unpinning the max matplotlib pin in ARMI opened some floodgates for other upgrades, specifically numpy. I ended up with one test failing in test_historyTracker.py because some zeroes were being saved as np.int64 in the database and that was getting processed into strings when using getHistory. So that's where those forced int() pieces came from. The rest is self explanatory numpy deprecation warnings.

Why is the change being made?

matplotlib v3.8 being the max version doesn't always work with higher python versions. The pip resolution in github actions is not behaving the same elsewhere. So let's just fix root cause of the max pin instead.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@john-science
Copy link
Member

Okay, I see broken tests. But I like the IDEA of the PR, and am happy to support it in whatever way you need.

@john-science john-science self-requested a review December 28, 2024 14:51
@john-science john-science added the cleanup Code/comment cleanup: Low Priority label Dec 28, 2024
@opotowsky
Copy link
Member Author

opotowsky commented Dec 30, 2024

Okay, I see broken tests. But I like the IDEA of the PR, and am happy to support it in whatever way you need.

Yep I'm just playing around trying to find a set of deps that works with the unpinned matplotlib for higher python versions.

Right now py39 and py310 are failing, as expected. I have to find the place in the code responsible for returning the np.int64 dudes and force an int, otherwise we are close!

@opotowsky opotowsky changed the title [WIP, need CI] Unsettle some dependencies to unpin the max matplotlib version Unpin the max matplotlib version, which upgrades numpy Dec 31, 2024
@opotowsky
Copy link
Member Author

@john-science This is ready now! let me know if it's important enough for the release notes. I guessed "no" but I'm willing to be wrong.

Copy link
Member

@john-science john-science left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks so much!

@john-science john-science merged commit 1920ff0 into main Jan 3, 2025
22 checks passed
@john-science john-science deleted the matplotlib branch January 3, 2025 16:51
drewj-tp added a commit that referenced this pull request Jan 10, 2025
…1915

* origin/main:
  Unpinning the max `matplotlib` version (#2040)
  Raising error in invalid xsTypeNum condition (#2042)
  Starting the armi.testing modules (#2028)
  Sorting imports with ruff (#2025)
  Identifying all first-order dependencies (#2039)
  Removing dependence on six (#2037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code/comment cleanup: Low Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants