Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing default of syncDbAfterWrite to True #1968

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

zachmprince
Copy link
Contributor

@zachmprince zachmprince commented Oct 22, 2024

What is the change?

syncDbAfterWrite now defaults to True.

Why is the change being made?

This setting enables the database to be written to the working directory each time the database interface has an interaction. This basically ensures that a relatively current database is written if a job fails in a way that prevents going through interactError. There is potential overhead in the operation due to the file I/O. But I checked with a large model, where the runtime difference would be greatest, and it didn't have any noticeable impact on runtime.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@zachmprince zachmprince added the feature request Smaller user request label Oct 22, 2024
@zachmprince zachmprince marked this pull request as ready for review October 22, 2024 16:44
doc/release/0.4.rst Outdated Show resolved Hide resolved
@john-science john-science merged commit 63948ad into terrapower:main Oct 23, 2024
11 checks passed
drewj-tp added a commit that referenced this pull request Oct 23, 2024
* main:
  Changing default of syncDbAfterWrite to True (#1968)
  Removing upper bound pin on HDF5 (#1932)
drewj-tp added a commit that referenced this pull request Oct 23, 2024
* main:
  Skipping XS generation when using tight coupling (#1963)
  Renaming Database3 to Database, but preserving the API (#1961)
  Changing default of syncDbAfterWrite to True (#1968)
  Removing upper bound pin on HDF5 (#1932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants