Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip XS generation when calculation uses tight coupling #1963

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

keckler
Copy link
Member

@keckler keckler commented Oct 20, 2024

What is the change?

When tight coupling is on, the regeneration of cross sections at the interactEveryNode() step might not be that useful because the cross sections are guaranteed to change during coupled iterations (assuming that LatticePhysicsFrequency is high enough to trigger during coupled iterations). Since the results from the interactEveryNode() step in this case are just an initial guess, it might not be very important to have super precise cross sections. Therefore if some cross sections already exist at interactEveryNode(), this PR skips their regeneration.

Why is the change being made?

Cross section generation is expensive. This change is being made primarily for performance reasons.


Checklist

  • The release notes have been updated if necessary.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in pyproject.toml.

@keckler keckler marked this pull request as ready for review October 22, 2024 20:51
@onufer onufer self-requested a review October 23, 2024 14:50
@john-science
Copy link
Member

Holler when you guys want this merged.

@john-science john-science added the feature request Smaller user request label Oct 23, 2024
@john-science john-science merged commit 3961c14 into main Oct 23, 2024
15 checks passed
@john-science john-science deleted the skipXsGenWhenCoupled branch October 23, 2024 21:43
drewj-tp added a commit that referenced this pull request Oct 23, 2024
* main:
  Skipping XS generation when using tight coupling (#1963)
  Renaming Database3 to Database, but preserving the API (#1961)
  Changing default of syncDbAfterWrite to True (#1968)
  Removing upper bound pin on HDF5 (#1932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Smaller user request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants