Skip XS generation when calculation uses tight coupling #1963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
When tight coupling is on, the regeneration of cross sections at the
interactEveryNode()
step might not be that useful because the cross sections are guaranteed to change during coupled iterations (assuming thatLatticePhysicsFrequency
is high enough to trigger during coupled iterations). Since the results from theinteractEveryNode()
step in this case are just an initial guess, it might not be very important to have super precise cross sections. Therefore if some cross sections already exist atinteractEveryNode()
, this PR skips their regeneration.Why is the change being made?
Cross section generation is expensive. This change is being made primarily for performance reasons.
Checklist
doc
folder.pyproject.toml
.