Creating versions setting section #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 23, 2023
|
@drewj-usnctech @albeanth @sombrereau Just FYI. |
|
@opotowsky Even if everyone likes this PR, I will want to talk to you about WHEN will be a good time to merge it. (I think it wouldn't affect downstream applications, but still we'll want to touch base.) |
albeanth
reviewed
May 23, 2023
|
I like this PR but I think it will have (very) minor implications on downstream applications. I'll touch base offline. |
opotowsky
reviewed
May 23, 2023
opotowsky
approved these changes
May 23, 2023
albeanth
approved these changes
May 23, 2023
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Jun 1, 2023
* main: (23 commits) block converters preserve flags (terrapower#1271) Fixed float decimals v3 (terrapower#1283) Fixed string format error for snapshots (terrapower#1277) Pinning the versions of yamlize and ruamel (terrapower#1281) Releasing v0.2.7 (terrapower#1276) Creating verisons setting section (terrapower#1274) Adding to GlobalFluxOptions docstring (terrapower#1273) Harmonize material names and class names (terrapower#1270) Removing Component.getMassDensity (terrapower#1266) Cleaning up language for our versioning rules (terrapower#1175) Fixing the Settings Report in the Docs (terrapower#1264) Fixing getTemperatureAtDensity to use non-pseduo density (terrapower#1262) Fixing settings report docs from terrapower#1207 (terrapower#1263) Update test_components.py (terrapower#1261) Update gamma Uniform Mesh Converter (terrapower#1213) Updating way that settings report defaults are printed (terrapower#1207) Fixing UserPlugins.defineFlag (terrapower#1241) quick bug fix for PR 1239 (terrapower#1260) New Option to Control Lattice Physics Update Frequency (terrapower#1239) Fix a bug in database compare. (terrapower#1258) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing metadata section of settings files and creating a "versions" section under settings. Some of the problems this attempts to solve are:
NOTE - This is SORT-OF an API-breaking change. So it comes with an ARMI version bump. However, I expect that it won't actually break anything downstream. It will allow applications and plugins to record their versions when writing a settings YAML file. But... they don't have to or anything.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.