Update gamma Uniform Mesh Converter #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nebbychadnezzar
approved these changes
Mar 24, 2023
mgjarrett
commented
Mar 28, 2023
|
@mgjarrett This PR is waiting for a downstream project. Let's find a time to merge this "soon". |
|
This PR is ready, but I am converting to draft while we figure out downstream merge dependencies. |
|
This has been dormant for awhile because it was deprioritized in favor of other work in downstream repos. Merging with the up-to-date main now and making sure all of the CI still passes. |
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Jun 1, 2023
* main: (23 commits) block converters preserve flags (terrapower#1271) Fixed float decimals v3 (terrapower#1283) Fixed string format error for snapshots (terrapower#1277) Pinning the versions of yamlize and ruamel (terrapower#1281) Releasing v0.2.7 (terrapower#1276) Creating verisons setting section (terrapower#1274) Adding to GlobalFluxOptions docstring (terrapower#1273) Harmonize material names and class names (terrapower#1270) Removing Component.getMassDensity (terrapower#1266) Cleaning up language for our versioning rules (terrapower#1175) Fixing the Settings Report in the Docs (terrapower#1264) Fixing getTemperatureAtDensity to use non-pseduo density (terrapower#1262) Fixing settings report docs from terrapower#1207 (terrapower#1263) Update test_components.py (terrapower#1261) Update gamma Uniform Mesh Converter (terrapower#1213) Updating way that settings report defaults are printed (terrapower#1207) Fixing UserPlugins.defineFlag (terrapower#1241) quick bug fix for PR 1239 (terrapower#1260) New Option to Control Lattice Physics Update Frequency (terrapower#1239) Fix a bug in database compare. (terrapower#1258) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update gamma uniform mesh converter to avoid numerical diffusion of the neutron flux.
Previous uniform mesh converter updates were made to avoid direct numerical diffusion, which was happening when a parameter was mapped in both directions in the uniform mesh converter (both into and out of the uniform mesh). #992
An additional source of numerical diffusion was recently discovered through more indirect channels. When one parameter is mapped in one direction, and then another parameter is derived from that mapped parameter, and then mapped back to the original mesh, this causes numerical diffusion.
For example, when the neutron flux is originally read onto the uniform mesh and then mapped to the non-uniform mesh, there is an initial step of numerical diffusion which is unavoidable. When a gamma flux calculation is performed, the neutron flux is then mapped back to a uniform mesh to create the gamma source; this contributes more numerical diffusion. This latter instance of numerical diffusion can be avoided by re-reading the neutron flux directly onto the uniform mesh reactor instead of mapping it in from the non-uniform reactor. This PR aims to remove this unnecessary diffusion by not mapping flux or flux-derived parameters (like power) in the non-uniform -> uniform direction.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.