Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TD_frac for consistency #1140

Merged
merged 12 commits into from
Feb 2, 2023

Conversation

keckler
Copy link
Member

@keckler keckler commented Feb 1, 2023

This does the same exact thing as #1114 . However, that PR was having some mysterious issues where the tests were passing locally, but not via GH actions. This mysterious behavior was isolated to a specific unit test that was previously implemented in its own file at materials/tests/test_uraniumOxide. For an unknown reason, that was causing the problems. Moving the test into materials/tests/test_materials seems to have fixed the problem.

Description

This closes #1112 by ensuring that the TD_frac material modification on UraniumOxide and MOX both actually change the density as they are supposed to.

This is implemented mainly via changes to the SimpleSolid class and by making setting a default value of 1.0 to the theoreticalDensityFrac material attribute.

Other than that, ThoriumOxide was modified to be consistent in its usage of the new theoreticalDensityFrac

This doesn't touch anything in the API, so users should not notice any changes except the fact that TD_frac is now correctly applied, so their results might change if they were using the framework oxide classes.


Checklist

  • This PR has only one purpose or idea.
  • Tests have been added/updated to verify that the new/changed code works.
  • The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
  • The documentation is still up-to-date in the doc folder.
  • The dependencies are still up-to-date in setup.py.

@keckler keckler requested a review from john-science February 1, 2023 18:47
@john-science john-science changed the title TD_frac updates and consistency, attempt 4 Updating TD_frac for consistency Feb 2, 2023
@john-science john-science added the enhancement New feature or request label Feb 2, 2023
@john-science john-science merged commit cfa6935 into terrapower:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TD_frac for UraniumOxide and MOX doesn't do anything
2 participants