Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same exact thing as #1114 . However, that PR was having some mysterious issues where the tests were passing locally, but not via GH actions. This mysterious behavior was isolated to a specific unit test that was previously implemented in its own file at
materials/tests/test_uraniumOxide
. For an unknown reason, that was causing the problems. Moving the test intomaterials/tests/test_materials
seems to have fixed the problem.Description
This closes #1112 by ensuring that the
TD_frac
material modification onUraniumOxide
andMOX
both actually change the density as they are supposed to.This is implemented mainly via changes to the
SimpleSolid
class and by making setting a default value of 1.0 to thetheoreticalDensityFrac
material attribute.Other than that,
ThoriumOxide
was modified to be consistent in its usage of the newtheoreticalDensityFrac
This doesn't touch anything in the API, so users should not notice any changes except the fact that TD_frac is now correctly applied, so their results might change if they were using the framework oxide classes.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.