-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD_frac
updates and consistency
#1114
Conversation
…nd set a default for the parameter
I am testing our internal projects against this change now, and will update when I know that those work. |
This appears to be working. |
I see something is failing... grrr |
This reverts commit dcfa4a2.
Okay @john-science , this is ready for review. |
And now I need to change this to account for #1062 |
I have no idea why these tests are failing. They all pass locally, and looking at the ones that claim to be failing, they seem pretty random... |
@john-science Have you seen this before? The tests passed with Python3.9 but not 3.10... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to update the user docs to explain this in the materials docs.
Description
This closes #1112 by ensuring that the
TD_frac
material modification onUraniumOxide
andMOX
both actually change the density as they are supposed to.This is implemented mainly via changes to the
SimpleSolid
class and by making setting a default value of 1.0 to thetheoreticalDensityFrac
material parameter.Other than that, the other material classes that were originally using some form of a
theoreticalDensityFrac
variable were modified to be consistent in their usage of that variable. Those other material classes includedThoriumOxide
and.B4C
This doesn't touch anything in the API, so users should not notice any changes except the fact that
TD_frac
is now correctly applied, so their results might change if they were using the framework oxide classes.EDIT: This PR no longer makes any changes to B4C. A new ticket was opened to address that class.
Checklist
doc/release/0.X.rst
) are up-to-date with any bug fixes or new features.doc
folder.setup.py
.