Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: GLFW Builds of Ghostty, Changes to Main Specs For Compatibility #2788

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

ShinyGil
Copy link
Contributor

@ShinyGil ShinyGil commented Dec 29, 2024

NOTE: The GLFW build of Tip currently fails due to some sort of regression. The spec sheet itself should be fine.

@korewaChino
Copy link
Contributor

why's the GLFW version not the main version anyway?

@ShinyGil
Copy link
Contributor Author

why's the GLFW version not the main version anyway?

The dev claims it is unstable and bad to use, but most people prefer it and have no issues aside from a lack of features. :/

@madonuko
Copy link
Member

https://github.com/terrapkg/packages/actions/runs/12535874658/job/34958687189?pr=2788#step:7:14480

I saw you tried to add those devel packages to buildrequires, but they unfortunately are not used. This is a limitation of the build script provided by upstream. (I spent too much time trying to get dynamic linking to work but to no avail)

@ShinyGil
Copy link
Contributor Author

https://github.com/terrapkg/packages/actions/runs/12535874658/job/34958687189?pr=2788#step:7:14480

I saw you tried to add those devel packages to buildrequires, but they unfortunately are not used. This is a limitation of the build script provided by upstream. (I spent too much time trying to get dynamic linking to work but to no avail)

Blegh, fun. I'll clean that up a bit then. I think I know which ones to remove.

@ShinyGil
Copy link
Contributor Author

https://github.com/terrapkg/packages/actions/runs/12535874658/job/34958687189?pr=2788#step:7:14480

I saw you tried to add those devel packages to buildrequires, but they unfortunately are not used. This is a limitation of the build script provided by upstream. (I spent too much time trying to get dynamic linking to work but to no avail)

In this case though, should we remove the pkg-config patch entirely instead of just commenting it?

@madonuko
Copy link
Member

you could remove that, I left that there just to basically wait for some miracle to happen

@ShinyGil
Copy link
Contributor Author

you could remove that, I left that there just to basically wait for some miracle to happen

I will back up the current specs and unused patches to maybe revisit this, for now I will clean things up.

@raboneko
Copy link
Member

💚 All backports created successfully

Status Branch Result
f39
f40
f41
el10

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

madonuko pushed a commit that referenced this pull request Dec 31, 2024
…2788) (#2800)

* Add: GLFW builds of Ghostty, edit existing builds for shared deps, add build deps to be explicitly called (just in case), some cleanup

* Add: Add warning about GLFW builds possibly being unstable

* Fix: Removed duplicate text (thanks mouse)

* Update ghostty-nightly.spec

Signed-off-by: Gil <rockgrub@protonmail.com>

* Cleanup: Removed unused build deps, removed unused patches (for now?)

* Fix: New icon size in Tip GTK (will need to be done in stable in 1.0.1), minor changes to summaries

* Resolve: Date conflict

---------

Signed-off-by: Gil <rockgrub@protonmail.com>
(cherry picked from commit d990cae)

Co-authored-by: Gil <rockgrub@protonmail.com>
madonuko pushed a commit that referenced this pull request Dec 31, 2024
…2788) (#2799)

* Add: GLFW builds of Ghostty, edit existing builds for shared deps, add build deps to be explicitly called (just in case), some cleanup

* Add: Add warning about GLFW builds possibly being unstable

* Fix: Removed duplicate text (thanks mouse)

* Update ghostty-nightly.spec

Signed-off-by: Gil <rockgrub@protonmail.com>

* Cleanup: Removed unused build deps, removed unused patches (for now?)

* Fix: New icon size in Tip GTK (will need to be done in stable in 1.0.1), minor changes to summaries

* Resolve: Date conflict

---------

Signed-off-by: Gil <rockgrub@protonmail.com>
(cherry picked from commit d990cae)

Co-authored-by: Gil <rockgrub@protonmail.com>
madonuko pushed a commit that referenced this pull request Dec 31, 2024
…2788) (#2798)

* Add: GLFW builds of Ghostty, edit existing builds for shared deps, add build deps to be explicitly called (just in case), some cleanup

* Add: Add warning about GLFW builds possibly being unstable

* Fix: Removed duplicate text (thanks mouse)

* Update ghostty-nightly.spec

Signed-off-by: Gil <rockgrub@protonmail.com>

* Cleanup: Removed unused build deps, removed unused patches (for now?)

* Fix: New icon size in Tip GTK (will need to be done in stable in 1.0.1), minor changes to summaries

* Resolve: Date conflict

---------

Signed-off-by: Gil <rockgrub@protonmail.com>
(cherry picked from commit d990cae)

Co-authored-by: Gil <rockgrub@protonmail.com>
madonuko pushed a commit that referenced this pull request Dec 31, 2024
…2788) (#2797)

* Add: GLFW builds of Ghostty, edit existing builds for shared deps, add build deps to be explicitly called (just in case), some cleanup

* Add: Add warning about GLFW builds possibly being unstable

* Fix: Removed duplicate text (thanks mouse)

* Update ghostty-nightly.spec

Signed-off-by: Gil <rockgrub@protonmail.com>

* Cleanup: Removed unused build deps, removed unused patches (for now?)

* Fix: New icon size in Tip GTK (will need to be done in stable in 1.0.1), minor changes to summaries

* Resolve: Date conflict

---------

Signed-off-by: Gil <rockgrub@protonmail.com>
(cherry picked from commit d990cae)

Co-authored-by: Gil <rockgrub@protonmail.com>
@Uzaaft
Copy link

Uzaaft commented Dec 31, 2024

why's the GLFW version not the main version anyway?

The dev claims it is unstable and bad to use, but most people prefer it and have no issues aside from a lack of features. :/

Just to extend on this:
The GLFW version is not stable, and according to the creator also has memory leaks. It shouldnt be packaged. Screenshot from another GH Issue/PR:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants