Missing ca_cert_identifier for sqlserver engine aws rds instance
#179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent PR (#174) included changes for the `ca_cert_identifier` variable, but it does not have it on the `aws_db_instance.this_mssql` resources (sqlserver engine types). This may be important for some AWS users. Also, we've briefly tested that the change can be applied without destroying the resource, but requires `apply-immediately` to be set .
|
I think this should be closed in favor to #178 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PR (#174) included changes for the
ca_cert_identifiervariable, but it does not have it on theaws_db_instance.this_mssqlresources (sqlserver engine types). This may be important for some AWS users. Also, we've briefly tested that the change can be applied without destroying the resource, but requiresapply-immediatelyto be set .Description
Please explain the changes you made here and link to any relevant issues.