-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature / Combined Updates #178
Feature / Combined Updates #178
Conversation
@antonbabenko let me know if there is anything I can do to help speed up the review process and get to a resolution, thank you! |
…raform-aws-rds into feature/combined-updates
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
name
andname_prefix
on option group, subnet group, and parameter group. Previously all defaulted to use a prefix but there are now 3 scenarios supported (as was the original intent I believe). a user can provide a name to an existing group to use (create flag = false), a user can provide a name to create a new group (create flag = true), a user can provide a name prefix to create a new group (create flag = true && use prefix = true).Name
tag was updated to be consistent with what is selected from the above coalesce results to be consistentThis PR is rather quite large but that is due to the culmination of changes that have been building up in open PRs that have gone stale, did not function as intended, etc. I have tested and validated these changes and they appear to be working as intended - currently this setup is used in production on a MSSQL instance without issue. Hopefully we can get this resolved quickly, let me know if I can be of any help!
Note - at minimum this supersedes and closes the following PRs if merged: #177, #98, #121, #115, #175, #145 - there may be more but that can be determined after resolution