Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature / Combined Updates #178

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Dec 16, 2019

Description

  • Add MSSQL active directory auth per https://www.terraform.io/docs/providers/aws/r/db_instance.html\#domain
  • Bump pre-commit versions and run pre-commit to generate documentation changes
  • Mark database password output as sensitive to avoid exposing in stdout output
  • Correct usage of name and name_prefix on option group, subnet group, and parameter group. Previously all defaulted to use a prefix but there are now 3 scenarios supported (as was the original intent I believe). a user can provide a name to an existing group to use (create flag = false), a user can provide a name to create a new group (create flag = true), a user can provide a name prefix to create a new group (create flag = true && use prefix = true).
  • Add support for certificate authority setting and its associated output
  • Add delete timeout configuration for option group, currently set to resource default
  • Subnet group, option group, and parameter group names and the database instance identifier have been made lowercase as this is either required and/or when created manual they will be converted to lowercase (tested through console)
  • The use of name, name prefix, and identifier have been updated to be consistent. when a group name is not provided, the db instance identifier will be used, and likewise for name prefix. the Name tag was updated to be consistent with what is selected from the above coalesce results to be consistent

This PR is rather quite large but that is due to the culmination of changes that have been building up in open PRs that have gone stale, did not function as intended, etc. I have tested and validated these changes and they appear to be working as intended - currently this setup is used in production on a MSSQL instance without issue. Hopefully we can get this resolved quickly, let me know if I can be of any help!

Note - at minimum this supersedes and closes the following PRs if merged: #177, #98, #121, #115, #175, #145 - there may be more but that can be determined after resolution

@bryantbiggs
Copy link
Member Author

@antonbabenko let me know if there is anything I can do to help speed up the review process and get to a resolution, thank you!

@bryantbiggs bryantbiggs changed the title Feature/combined updates Feature / Combined Updates Dec 16, 2019
@bryantbiggs bryantbiggs closed this Jan 7, 2020
@bryantbiggs bryantbiggs deleted the feature/combined-updates branch February 16, 2021 15:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant